----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8563/#review14547 -----------------------------------------------------------
Pl. close this review as submitted. Create new one or commit directly to branch. - Rohit Yadav On Dec. 13, 2012, 2:07 a.m., Min Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8563/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2012, 2:07 a.m.) > > > Review request for cloudstack and Rohit Yadav. > > > Description > ------- > > Move all DB view DAO classes for list API from cloud-server project to > cloud-api project for future api-server bundle. > > > This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-527. > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/view/DBViewUtils.java PRE-CREATION > api/src/org/apache/cloudstack/api/view/ViewResponseHelper.java PRE-CREATION > api/src/org/apache/cloudstack/api/view/dao/DomainRouterJoinDao.java > PRE-CREATION > api/src/org/apache/cloudstack/api/view/dao/DomainRouterJoinDaoImpl.java > PRE-CREATION > api/src/org/apache/cloudstack/api/view/dao/EventJoinDao.java PRE-CREATION > api/src/org/apache/cloudstack/api/view/dao/EventJoinDaoImpl.java > PRE-CREATION > api/src/org/apache/cloudstack/api/view/dao/InstanceGroupJoinDao.java > PRE-CREATION > api/src/org/apache/cloudstack/api/view/dao/InstanceGroupJoinDaoImpl.java > PRE-CREATION > api/src/org/apache/cloudstack/api/view/dao/ProjectAccountJoinDao.java > PRE-CREATION > api/src/org/apache/cloudstack/api/view/dao/ProjectAccountJoinDaoImpl.java > PRE-CREATION > api/src/org/apache/cloudstack/api/view/dao/ProjectInvitationJoinDao.java > PRE-CREATION > > api/src/org/apache/cloudstack/api/view/dao/ProjectInvitationJoinDaoImpl.java > PRE-CREATION > api/src/org/apache/cloudstack/api/view/dao/ProjectJoinDao.java PRE-CREATION > api/src/org/apache/cloudstack/api/view/dao/ProjectJoinDaoImpl.java > PRE-CREATION > api/src/org/apache/cloudstack/api/view/dao/ResourceTagJoinDao.java > PRE-CREATION > api/src/org/apache/cloudstack/api/view/dao/ResourceTagJoinDaoImpl.java > PRE-CREATION > api/src/org/apache/cloudstack/api/view/dao/SecurityGroupJoinDao.java > PRE-CREATION > api/src/org/apache/cloudstack/api/view/dao/SecurityGroupJoinDaoImpl.java > PRE-CREATION > api/src/org/apache/cloudstack/api/view/dao/UserAccountJoinDao.java > PRE-CREATION > api/src/org/apache/cloudstack/api/view/dao/UserAccountJoinDaoImpl.java > PRE-CREATION > api/src/org/apache/cloudstack/api/view/dao/UserVmJoinDao.java PRE-CREATION > api/src/org/apache/cloudstack/api/view/dao/UserVmJoinDaoImpl.java > PRE-CREATION > server/src/com/cloud/api/ApiDBUtils.java d5cce52 > server/src/com/cloud/api/ApiResponseHelper.java 1e2b87d > server/src/com/cloud/configuration/DefaultComponentLibrary.java 2dd46fd > server/src/com/cloud/event/dao/EventJoinDao.java d67653d > server/src/com/cloud/event/dao/EventJoinDaoImpl.java be2a6dc > server/src/com/cloud/network/security/SecurityGroupManagerImpl.java a9d1f0b > server/src/com/cloud/network/security/dao/SecurityGroupJoinDao.java 30c0897 > server/src/com/cloud/network/security/dao/SecurityGroupJoinDaoImpl.java > 6ecb258 > server/src/com/cloud/projects/ProjectManagerImpl.java 7c97af2 > server/src/com/cloud/projects/dao/ProjectAccountJoinDao.java bdee7aa > server/src/com/cloud/projects/dao/ProjectAccountJoinDaoImpl.java afea1cb > server/src/com/cloud/projects/dao/ProjectInvitationJoinDao.java 2ee7de0 > server/src/com/cloud/projects/dao/ProjectInvitationJoinDaoImpl.java 0ee0ef8 > server/src/com/cloud/projects/dao/ProjectJoinDao.java c5cc422 > server/src/com/cloud/projects/dao/ProjectJoinDaoImpl.java 81ccb7f > server/src/com/cloud/server/ManagementServerImpl.java a196cd3 > server/src/com/cloud/tags/TaggedResourceManagerImpl.java 0f82142 > server/src/com/cloud/tags/dao/ResourceTagJoinDao.java 8dd3d82 > server/src/com/cloud/tags/dao/ResourceTagJoinDaoImpl.java 3c2dafa > server/src/com/cloud/user/AccountManagerImpl.java e1b806d > server/src/com/cloud/user/dao/UserAccountJoinDao.java 39a82d0 > server/src/com/cloud/user/dao/UserAccountJoinDaoImpl.java e854ae5 > server/src/com/cloud/vm/UserVmManagerImpl.java a8241d0 > server/src/com/cloud/vm/dao/DomainRouterJoinDao.java 9bb03be > server/src/com/cloud/vm/dao/DomainRouterJoinDaoImpl.java 38839e3 > server/src/com/cloud/vm/dao/InstanceGroupJoinDao.java 64599be > server/src/com/cloud/vm/dao/InstanceGroupJoinDaoImpl.java aa20b77 > server/src/com/cloud/vm/dao/UserVmJoinDao.java 7788a62 > server/src/com/cloud/vm/dao/UserVmJoinDaoImpl.java b20e53f > server/test/com/cloud/network/security/SecurityGroupManagerImpl2Test.java > 46b7018 > > Diff: https://reviews.apache.org/r/8563/diff/ > > > Testing > ------- > > > Thanks, > > Min Chen > >