-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8037/#review14495
-----------------------------------------------------------
Ship it!
commit 0ba355fbc20411890b74f7b6f33edc057c493259
Author: Simon Waterhouse <simon.waterho...@citrix.com>
Date: Tue Nov 13 11:59:08 2012 +0000
CLOUDSTACK-284: listVirtualMachines when zoneid passed
When zoneid is passed an no state is specified listVIrtualMachines does
not return the destroyed vms. This patch fixes the issue.
Signed-off-by: Prasanna Santhanam <t...@apache.org>
Applied to master, please close as submitted
- Prasanna Santhanam
On Nov. 13, 2012, 12:16 p.m., Simon Waterhouse wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8037/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2012, 12:16 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Fixed CLOUDSTACK-284 by removing the code that filtered out "Destroyed" VMs
> if the zone was specified.
>
>
> This addresses bug CLOUDSTACK-284.
>
>
> Diffs
> -----
>
> server/src/com/cloud/vm/UserVmManagerImpl.java a2a548f
>
> Diff: https://reviews.apache.org/r/8037/diff/
>
>
> Testing
> -------
>
> Ran HTTP "listVirtualMachines" query both with and without "zone" parameter.
> Test cases, all performed as expected
> 1. 0 VMs
> 2. 1 running VM
> 3. 1 running, 1 destroyed VM
> 4. 2 destroyed VMs
>
>
> Thanks,
>
> Simon Waterhouse
>
>
