Hi Likitha,

For the response command, I changed the entity.java to EntityMapper.java.
So the annotation @Entity changes to @EntityMapper. I found there are already 
existing Entity.

IS this ok?
Thanks,
-Fang

From: Likitha Shetty [mailto:nore...@reviews.apache.org] On Behalf Of Likitha 
Shetty
Sent: Wednesday, December 12, 2012 9:40 PM
To: Rohit Yadav; Fang Wang
Cc: cloudstack; Likitha Shetty
Subject: Review Request: API_refactoring: add parameter annotation for user 
'security-group' group

This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/8565/


Review request for cloudstack, Rohit Yadav and Fang Wang.
By Likitha Shetty.
Description

Add the entityType to the parameter annotation.

Annotate SecurityGroupRules response

Bugs: CLOUDSTACK-518
Diffs

 *   
api/src/org/apache/cloudstack/api/command/user/securitygroup/AuthorizeSecurityGroupEgressCmd.java
 (566e5c0)
 *   
api/src/org/apache/cloudstack/api/command/user/securitygroup/AuthorizeSecurityGroupIngressCmd.java
 (b5e6aa2)
 *   
api/src/org/apache/cloudstack/api/command/user/securitygroup/CreateSecurityGroupCmd.java
 (b83a972)
 *   
api/src/org/apache/cloudstack/api/command/user/securitygroup/DeleteSecurityGroupCmd.java
 (5ca76ef)
 *   
api/src/org/apache/cloudstack/api/command/user/securitygroup/ListSecurityGroupsCmd.java
 (0149a0a)
 *   
api/src/org/apache/cloudstack/api/command/user/securitygroup/RevokeSecurityGroupEgressCmd.java
 (9783218)
 *   
api/src/org/apache/cloudstack/api/command/user/securitygroup/RevokeSecurityGroupIngressCmd.java
 (34c0004)
 *   api/src/org/apache/cloudstack/api/response/SecurityGroupRuleResponse.java 
(206e5fb)

View Diff<https://reviews.apache.org/r/8565/diff/>


Reply via email to