----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8448/#review14269 -----------------------------------------------------------
Ship it! Applied in api_refactoring; commit bba96254f500f90c05c8059dfe7938fb1857fe7f Author: Min Chen <min.c...@citrix.com> Date: Mon Dec 10 13:52:33 2012 -0800 Refactoring ListVMGroupsCmd and InstanceGroupResponse. - Rohit Yadav On Dec. 10, 2012, 9:57 p.m., Min Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8448/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2012, 9:57 p.m.) > > > Review request for cloudstack and Rohit Yadav. > > > Description > ------- > > Refactoring ListVMGroupsCmd and InstanceGroupResponse. > > > This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-527. > > > Diffs > ----- > > api/src/com/cloud/server/ManagementService.java 75c042d > api/src/org/apache/cloudstack/api/ResponseGenerator.java b0a2faf > api/src/org/apache/cloudstack/api/command/user/vmgroup/ListVMGroupsCmd.java > c94571b > api/src/org/apache/cloudstack/api/response/InstanceGroupResponse.java > ec92397 > api/src/org/apache/cloudstack/api/view/vo/InstanceGroupJoinVO.java > PRE-CREATION > server/src/com/cloud/api/ApiDBUtils.java a86f09b > server/src/com/cloud/api/ApiResponseHelper.java 992c0f4 > server/src/com/cloud/api/ApiServer.java 183249f > server/src/com/cloud/event/dao/EventJoinDaoImpl.java 91e7f36 > server/src/com/cloud/network/security/dao/SecurityGroupJoinDaoImpl.java > 8afb0cd > server/src/com/cloud/server/ManagementServerImpl.java be6bbef > server/src/com/cloud/tags/dao/ResourceTagJoinDaoImpl.java 59f8cad > server/src/com/cloud/vm/dao/DomainRouterJoinDaoImpl.java f7a9146 > server/src/com/cloud/vm/dao/InstanceGroupJoinDao.java PRE-CREATION > server/src/com/cloud/vm/dao/InstanceGroupJoinDaoImpl.java PRE-CREATION > setup/db/create-schema.sql d0c49c8 > > Diff: https://reviews.apache.org/r/8448/diff/ > > > Testing > ------- > > > Thanks, > > Min Chen > >