> On Dec. 10, 2012, 9:28 a.m., Abhinandan Prateek wrote: > > Ship It! > > Abhinandan Prateek wrote: > a db view would have been more optimal, but that can be done as part of > restructuring various such joins.
Applied in master, pl. close the review; CLOUDSTACK-596 : DeployVM command takes a lot of time to return job id Issue happens... authorKoushik Das <koushik....@citrix.com> Mon, 10 Dec 2012 08:26:51 +0000 (13:26 +0530) committerAbhinandan Prateek <aprat...@apache.org> Mon, 10 Dec 2012 09:32:53 +0000 (14:32 +0530) commit238c55fb6e40220cbbf60b241a902cdc7ccf8d37 - Rohit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8441/#review14237 ----------------------------------------------------------- On Dec. 10, 2012, 8:42 a.m., Koushik Das wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8441/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2012, 8:42 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. > > > Description > ------- > > Issue happens while deploying VM in advanced zone and 'networkids' parameter > is not passed to deployVM command. In this case CS tries to identify a > default guest network to be used for deploying VM. This logic is not > optimized and latency increases with increase in user accounts and guest > networks. Optimized logic for getting default network. > > > This addresses bug CLOUDSTACK-596. > > > Diffs > ----- > > server/src/com/cloud/network/NetworkManagerImpl.java b3fdf32 > server/src/com/cloud/network/dao/NetworkDao.java a2e37b7 > server/src/com/cloud/network/dao/NetworkDaoImpl.java cbfec89 > server/src/com/cloud/vm/UserVmManagerImpl.java 837e3f7 > server/test/com/cloud/vpc/dao/MockNetworkDaoImpl.java 2a675b3 > > Diff: https://reviews.apache.org/r/8441/diff/ > > > Testing > ------- > > Citrix QA verified it on a simulated environment (verified using a Citrix > private build). > Time taken for deployVM to return async. job id after fix is < 1s - tested > with over 4K accounts and 9500 VMs in simulator setup. Earlier it used to > take 14-15s for the same. > > > Thanks, > > Koushik Das > >
