On Fri, Dec 7, 2012 at 1:04 AM, Nitin Mehta <nitin.me...@citrix.com> wrote:
> Rohit - my answers inline.
>
> On 07-Dec-2012, at 1:12 AM, Rohit Yadav wrote:
>
>> I found following APIs which lack the (apiname, class and roles) mappings in 
>> commands.properties:
>>
>> CreatePrivateNetworkCmd

git blame says that Alena authored most of this file.  Alena?

>> DestroyConsoleProxyCmd
>> ListRecurringSnapshotScheduleCmd

These two have a ton of authors listed, and date back to 2010.
Perhaps someone knows more about them?

>
> I don't see all the three above in commands.properties neither any inherited 
> classes out of them. Not sure CreatePrivateNetwork but the other two look 
> good candidates for removal but do so carefully. Best would be if you can 
> catch hold of the authors somehow :)
>
>> ListTemplateOrIsoPermissionsCmd
>> UpdateTemplateOrIsoCmd
>> UpdateTemplateOrIsoPermissionsCmd
>>
>
> The above three classes shouldn't be removed. They are generic classes for 
> template / iso apis.
>
>> Do we need them, they are not listed on the apidocs (3.0.2 or 4.0) either.
>>
>> Regards.
>
>

Reply via email to