----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8248/ -----------------------------------------------------------
(Updated Nov. 29, 2012, 2:25 p.m.) Review request for cloudstack. Changes ------- Rohit, thanks for looking on this. > 1. Make python code PEP8 compliant Done. > 2. Chmod +x cs-bugtool, so it's an executable by default I am looking on the patch and see: create mode 100644 tools/support/README create mode 100755 tools/support/cs-bugtool so I assume it should be right. > 3. For the shebang interpretor use this path: /usr/bin/python Done. > Logs can have sensitive information (api, mgmt server logs for example with > auth, keys information, > access logs with full urls and sensitive values such as passwords and keys as > arguments). > Maybe we can identify such string patterns and search and replace them, add > code for doing that? I understand your concern but I am not sure how we can avoid this and how useful those information may be? We would have session keys in api-server.log which are expired and even having those session keys it would be extremely difficult to use them. Please correct me is I ma wrong? Maybe we can add some warring which will say, please be aware there may be some small piece of sensitive information in output file. And after all, user who uses this utility is going to send this info to some trusted person, support representative to process it. > 4. This is using zip (which assumes zip tool is preinstalled and which is the > case for most installations) We use Python zip library. >5. Add help docs in README. Done. Cheers, Radek. Description ------- The main purpose behind cs-bugtool is to make easier collecting logs required for CloudStack/CloudPlatform troubleshooting and it mainly comes from Support. cs-bugtool collects logs, system information and cloud database dump, compress everything and creates .zip archive file ready to share with others. For those familiar with Xen/XenServer cs-bugtool name may sound similar to xen-bugtool, this similarity is intentional. Current version of cs-bugtool collects: - basic system and environment information - CP/CS management service logs - basic system logs - cloud database Current version does not accept any arguments but this may changed in next iterations of cs-bugtool. We DO NOT collect and do not want to collect any sensitive information. If there is still any sensitive pice of information please let us know and we will try to remove it or replace by meaningless data. Diffs (updated) ----- tools/support/README PRE-CREATION tools/support/cs-bugtool PRE-CREATION Diff: https://reviews.apache.org/r/8248/diff/ Testing ------- I tested this on CS 3.0.4 and 3.0.5. Thanks, Radoslaw Smigielski
