I'll update the FS doc.
Alex and I had a discussion, and for the @parameter, the entityType annotation
for the REST API is a response class object.
For example,
@Parameter(name=ApiConstants.DOMAIN_ID, type=CommandType.LONG,
required=true, description="domain id of the new VM owner.",
entityType=DomainResponse.class)
private Long domainId;
The inner server will handle the domain, not the domainResponse.
-Fang
-----Original Message-----
From: Prachi Damle [mailto:nore...@reviews.apache.org] On Behalf Of Prachi Damle
Sent: Tuesday, November 20, 2012 4:46 PM
To: Prachi Damle; Alex Huang
Cc: cloudstack; Fang Wang
Subject: Re: Review Request: Changed the @Parameter for some VM group commands.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8133/#review13653
-----------------------------------------------------------
Hi Fang,
The entityType attribute on the @parameter should point to the actual interface
representing that entity in CloudStack. Not the Response Class for that entity.
For example:
@Parameter(name=ApiConstants.VIRTUAL_MACHINE_ID, type=CommandType.LONG,
required=true, description="the vm ID of the user VM to be moved",
entityType=VirtualMachine.class)
private Long virtualMachineId;
@Parameter(name=ApiConstants.DOMAIN_ID, type=CommandType.LONG,
required=true, description="domain id of the new VM owner.",
entityType=Domain.class)
private Long domainId;
- Prachi Damle
On Nov. 20, 2012, 2:05 a.m., Fang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8133/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2012, 2:05 a.m.)
>
>
> Review request for cloudstack, Prachi Damle and Alex Huang.
>
>
> Description
> -------
>
> Part of the API refactoring work. This is the initial modification to
> the @Parameter annotation for some commands in the VM group.
>
>
> This addresses bug cloudstack-518.
>
>
> Diffs
> -----
>
> api/src/com/cloud/api/Parameter.java 2da3c40
> api/src/org/apache/cloudstack/user/api/vm/commands/AssignVMCmd.java
> PRE-CREATION
> api/src/org/apache/cloudstack/user/api/vm/commands/CreateVMGroupCmd.java
> PRE-CREATION
> api/src/org/apache/cloudstack/user/api/vm/commands/DeleteVMGroupCmd.java
> PRE-CREATION
> api/src/org/apache/cloudstack/user/api/vm/commands/DeployVMCmd.java
> PRE-CREATION
>
> api/src/org/apache/cloudstack/user/api/vm/commands/DestroySystemVmCmd.
> java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/8133/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Fang Wang
>
>
