----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7824/#review13299 -----------------------------------------------------------
Ship it! Applied to master. Thanks for the patch! Please mark this review as closed / submitted. [master 67490f7] Display the reason which failed certificate generation fails within cloud.server.ConfigurationServerImpl.generateDefaultKeystore Author: Satoshi Kobayashi <satosh...@stratosphere.co.jp> 1 files changed, 1 insertions(+), 1 deletions(-) - Chip Childers On Nov. 1, 2012, 2:29 a.m., Satoshi Kobayashi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7824/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2012, 2:29 a.m.) > > > Review request for cloudstack. > > > Description > ------- > > The reason which failed in generation of the certificate is not displayed now. > At that time, IOException which does not include the reason is raised. > In order to solve the problem quickly, the reason should be included in the > message. > > (Now) > WARN [cloud.server.ConfigurationServerImpl] (main:) Would use fail-safe > keystore to continue. > java.io.IOException: Fail to generate certificate! > at > com.cloud.server.ConfigurationServerImpl.generateDefaultKeystore(ConfigurationServerImpl.java:490) > > (Fix) > WARN [cloud.server.ConfigurationServerImpl] (main:) Would use fail-safe > keystore to continue. > java.io.IOException: Fail to generate certificate!: sudo: sorry, you must > have a tty to run sudo > at > com.cloud.server.ConfigurationServerImpl.generateDefaultKeystore(ConfigurationServerImpl.java:490) > > > Diffs > ----- > > server/src/com/cloud/server/ConfigurationServerImpl.java > 3368c9ba1163d73fd7b012f164fde291b522f8e0 > > Diff: https://reviews.apache.org/r/7824/diff/ > > > Testing > ------- > > mvn clean install > mvn -pl :cloud-client-ui jetty:run > > And generation of the certificate was made to fail, checked it. > > > Thanks, > > Satoshi Kobayashi > >
