----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7923/#review13214 -----------------------------------------------------------
Ship it! Ship It! - Marcus Sorensen On Nov. 7, 2012, 7:31 a.m., Dave Cahill wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7923/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2012, 7:31 a.m.) > > > Review request for cloudstack, edison su and Marcus Sorensen. > > > Description > ------- > > In com.cloud.hypervisor.kvm.resource.BridgeVifDriver.java, in 2 places an if > block should have evaluated to true if trafficLabel was null, however it was > causing a NullPointerException instead. > > > Diffs > ----- > > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java > 116c09d > > Diff: https://reviews.apache.org/r/7923/diff/ > > > Testing > ------- > > Was running an Advanced Network with empty traffic labels, observed > NullPointerExceptions. > > Made change, deployed, NullPointerExceptions no longer experienced. > > > Thanks, > > Dave Cahill > >
