A gentle reminder!
- Thanks, Deepti From: deepti dohare [mailto:nore...@reviews.apache.org] On Behalf Of deepti dohare Sent: Friday, October 19, 2012 12:56 PM To: cloudstack; Deepti Dohare Subject: Review Request: CLOUDSTACK-357 ISOs can be deleted while still attached to a running VM, and they subsequently cannot be detached from a running VM This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7660/ Review request for cloudstack. By deepti dohare. Description Currently no warning or confirmation is given or required to delete an iso which is attached to a virtual machine. Fixing this issue using “force” delete option. If an admin or a user deletes an ISO which is attached to a vm: 1. Without force option; gives a warning that ISO is attached to vm “Failed to delete iso. It is currently attached to virtual machine. Please detach it before deleting”. 2. With force option: first detach the ISO from all vms and then deletes the ISO. Testing Verified locally. Tested for some cases: 1. Deleting iso(not attached to any vm) 2. Deleting iso(attached to multiple vms in same domain) 3. Deleting iso(attached to multiple vms in different domains) For admin/user Bugs: CLOUDSTACK-357 Diffs * api/src/com/cloud/api/commands/DeleteIsoCmd.java (70ce731) * server/src/com/cloud/template/TemplateManagerImpl.java (1e87de2) * server/src/com/cloud/vm/dao/UserVmDao.java (9fbcde3) * server/src/com/cloud/vm/dao/UserVmDaoImpl.java (db1d877) * ui/scripts/templates.js (a9fb371) View Diff<https://reviews.apache.org/r/7660/diff/>
