On 10/07/2012 08:50 AM, Alex Huang wrote:
Rohit, I checked in a fix for that but already. Probably the same as yours.
I just checked 9d94e6b1d320ab9c4d5e7c1796fd14332000213d but shouldn't we depend on "path.scripts" set by environment.properties for the management server?
Now we have another hardcoded path in the code which will haunt us on a later point in time.
Wido
--Alex From: Rohit Yadav [mailto:nore...@reviews.apache.org] On Behalf Of Rohit Yadav Sent: Saturday, October 06, 2012 11:45 PM To: David Nalley; Edison Su; Alex Huang Cc: cloudstack; Rohit Yadav Subject: Re: Review Request: CLOUDSTACK-278: Fix hard coded path in vmware This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7468/ Review request for cloudstack, David Nalley, edison su, and Alex Huang. By Rohit Yadav. Updated Oct. 7, 2012, 6:44 a.m. Description CLOUDSTACK-278: Fix hard coded path in vmware Fixes hard coded path to systemvm.iso in plugin hypervisor-vmware. Download the original patch and git am <patch-file>: http://patchbin.baagi.org/p?id=b6ppaf --- Posted with bhaisaab's rbtool fork: https://github.com/bhaisaab/RBTool Testing 4.0 Diffs * plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java (ce1af26) View Diff<https://reviews.apache.org/r/7468/diff/>
