Rohit, I know what happened now on this. Thanks for alerting me to the missing reviews. I had my bug filter built before the Ready For Review status was introduced into the Jira workflow so I've missed several of the bugs you've submitted reviews for. Hence, I didn't spend the time to track down committers for those reviews. We cleaned those up today.
Big thanks to Alena who helped out on most of these. --Alex > -----Original Message----- > From: Alex Huang > Sent: Friday, October 05, 2012 7:57 AM > To: cloudstack-dev@incubator.apache.org > Cc: Edison Su > Subject: RE: Pending commits/reviews on 4.0? > > I have been looking at the reviews. Right now, unless the review has a bug > that's designated to be fixed in 4.0.0 associated with it, it won't make it > in. > We're basically in lock down mode for the release. > > For the specific one you mentioned there, I did cherry-pick it over as it was > for bug 254. > > --Alex > > > -----Original Message----- > > From: Chip Childers [mailto:chip.child...@sungard.com] > > Sent: Friday, October 05, 2012 7:07 AM > > To: cloudstack-dev@incubator.apache.org > > Cc: Alex Huang; Edison Su > > Subject: Re: Pending commits/reviews on 4.0? > > > > On Fri, Oct 5, 2012 at 2:03 AM, Rohit Yadav <rohit.ya...@citrix.com> wrote: > > > Hi Alex/Edison, > > > > > > There are some pending reviews by myself and others and commits > > > (which > > are already in master) to be picked up in 4.0 branch. > > > For example; CLOUDSTACK-254: > > > https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a > > > =c ommit;h=3e7ba774f92c31ed5be649e4ed5ec315757ef93e > > > > > > Just wanted to re-bring this to our notice. > > > > > > Regards, > > > Rohit > > > > Rohit, > > > > It might help to specifically call out the commits that you know need > > to be cherry picked over to 4.0. I think that would make it easier to get > them over. > > > > -chip
