----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7461/ -----------------------------------------------------------
Review request for cloudstack. Description ------- Adjusts the check for qemu-img in isSnapshotSupported. We have been looking for 'qemu-img --help | grep convert | grep snapshot", but do not use qemu-img convert with the 'snapshot' flag anywhere in our code. We presumably will in the future, but this breaks functionality for current users who could otherwise use the existing snapshot feature. CentOS 6.3 (and presumably others) don't adhere to this output in their qemu-img --help, but still work for the existing version of snapshot feature. Diffs ----- plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java f6a6494 Diff: https://reviews.apache.org/r/7461/diff/ Testing ------- This comes into play during host capability detection. Verified that a CentOS 6.3 host now is detected as snapshot capable. Thanks, Marcus Sorensen
