> On Sept. 27, 2012, 6:49 a.m., Jessica Tomechak wrote: > > Some of the image file names don't match the introductory text, which makes > > me wonder whether it's the correct image file. It might be, if the same > > file is being reused for different tasks. Minor issue: some of the alt > > texts don't match the image file names. > > Radhika PC wrote: > Do you prefer to add multiple copies of the same image with diff names, > or what currently followed is fine ? > > Jessica Tomechak wrote: > It could be argued either way. I would lean toward re-using files, to > keep the image directory smaller. However, making appropriately named copies > makes the code much easier to read. It might be worth bringing up with the > community.
Fixed all the issues pointed out. added new image files. Fixed the alt texts. - Radhika ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7106/#review11968 ----------------------------------------------------------- On Sept. 28, 2012, 6:13 a.m., Radhika PC wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7106/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2012, 6:13 a.m.) > > > Review request for cloudstack and David Nalley. > > > Description > ------- > > files for VPC/inter vlan routing > > > Diffs > ----- > > docs/en-US/acquire-new-ip-for-vpc.xml PRE-CREATION > docs/en-US/add-gateway-vpc.xml PRE-CREATION > docs/en-US/add-loadbalancer-rule-vpc.xml PRE-CREATION > docs/en-US/add-portforward-rule-vpc.xml PRE-CREATION > docs/en-US/add-tier.xml PRE-CREATION > docs/en-US/add-vm-to-tier.xml PRE-CREATION > docs/en-US/add-vpc.xml PRE-CREATION > docs/en-US/configure-acl.xml PRE-CREATION > docs/en-US/configure-vpc.xml PRE-CREATION > docs/en-US/delete-reset-vpn.xml PRE-CREATION > docs/en-US/enable-disable-static-nat-vpc.xml PRE-CREATION > docs/en-US/inter-vlan-routing.xml PRE-CREATION > docs/en-US/release-ip-for-vpc.xml PRE-CREATION > docs/en-US/remove-tier.xml PRE-CREATION > docs/en-US/remove-vpc.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/7106/diff/ > > > Testing > ------- > > > Thanks, > > Radhika PC > >
