----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7304/#review11958 -----------------------------------------------------------
Ship it! Ship It! - edison su On Sept. 26, 2012, 11:12 p.m., Marcus Sorensen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7304/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2012, 11:12 p.m.) > > > Review request for cloudstack and edison su. > > > Description > ------- > > The code is unable to detect an existing pool, because we use a random UUID > each time. New Libvirt doesn't allow multiple pools to be defined to the same > storage. This patch generates a UUID based on the storage path, so that it > can be detected as existing and reused. It also cleans up no-op code and > adjusts the naming of a few things to clean up any confusion. > > > Diffs > ----- > > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java > 8246a5c > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java > 1381843 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/StorageAdaptor.java > ec10332 > > Diff: https://reviews.apache.org/r/7304/diff/ > > > Testing > ------- > > Broken environment would not launch VMs from an ISO, only the first would > succeed. Applied below patch, launched several VMs from ISO on several hosts. > Verified that same pool was being detected/reused. Also verified that pool > gets deleted when not in use. > > > Thanks, > > Marcus Sorensen > >
