----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7205/#review11931 -----------------------------------------------------------
Ship it! Ship It! - Vijay Venkatachalam On Sept. 26, 2012, 10:40 a.m., Deepak Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7205/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2012, 10:40 a.m.) > > > Review request for cloudstack, Devdeep Singh, Pranav Saxena, and Vijay > Venkatachalam. > > > Description > ------- > > Ids are used instead of UUIds for entities like template, serviceoffering. > Since NS will be making api calls on MS, so its better to use UUIDs > > > This addresses bug CS-15644. > > > Diffs > ----- > > api/src/com/cloud/agent/api/to/LoadBalancerTO.java 04f718e > api/src/com/cloud/network/as/AutoScaleVmGroup.java 7b882fc > api/src/com/cloud/network/lb/LoadBalancingRule.java e9cb6da > api/src/com/cloud/network/rules/LoadBalancer.java 9c67f29 > > plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java > 57e631e > > plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java > 1b5f17a > > plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java > 1a53e4d > server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java > ba3d689 > server/src/com/cloud/network/as/AutoScaleVmGroupVO.java 3de9f9b > server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 82b4dd4 > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > 163252f > > Diff: https://reviews.apache.org/r/7205/diff/ > > > Testing > ------- > > a. Manually tested with the Basic EIP/ELB zone by creating the autoscale > entities and AutoScaleVMGroup, then checking the string passed in the > NetScaler Box. > b. On firing the command string obtained from the NetScaler Box, a VM gets > deployed. > > > Thanks, > > Deepak Garg > >
