----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7243/#review11910 -----------------------------------------------------------
Ship it! Ship It! - edison su On Sept. 25, 2012, 3:19 a.m., Matty Courtney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7243/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2012, 3:19 a.m.) > > > Review request for cloudstack. > > > Description > ------- > > The passwd utility on Debian based distributions does not support the --stdin > option. I propose updating the script located at > http://cloudstack.org/dl/cloud-set-guest-password to use the chpasswd utility > instead. > > Additionally, Ubuntu 12.04 places DHCP lease information in /etc/dhcp/*. I > propose adding this to the search patch used when looking for the DHCP > server. > > Patch attached > > > This addresses bug CLOUDSTACK-196. > > > Diffs > ----- > > tools/guest_password/cloud-set-guest-password 97e6e3d > > Diff: https://reviews.apache.org/r/7243/diff/ > > > Testing > ------- > > Tested amended script on Redhat and Debian based distributions and confirmed > password is changed as and when expected > > > Thanks, > > Matty Courtney > >
