All, I'd like to create a branch for some of the JUnit tests that Yichi is creating. That way, we can accept the tests into the codebase (after reviews), but not apply them to master until 4.0 is stabilized. Any thoughts, questions or concerns?
-chip On Thu, Sep 20, 2012 at 11:41 PM, Yichi Lu <yichi...@sungard.com> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7204/ > ----------------------------------------------------------- > > Review request for cloudstack. > > > Description > ------- > > A junit test suite against api project. All unit tests are to be executed at > the api/unittest directory level by running "$ mvn test". > A directory: unittest was created under the project api. > The unit tests are used to test java classes and their methods. They are > intended to complement, not replace, the existing tests written in python > marvin. > packages used: surefire (v2.12.3), junit (v4.8.2). > While this particular suite is junit test suite against api project, it is > envisioned that eventually other suites be developed against other cloudstack > projects. > > > Diffs > ----- > > .gitignore d772031 > api/pom.xml db14775 > api/unittest/.gitignore PRE-CREATION > api/unittest/pom.xml PRE-CREATION > api/unittest/src/com/cloud/agent/api/.gitignore PRE-CREATION > api/unittest/src/com/cloud/agent/api/AttachIsoCommandTest.java PRE-CREATION > pom.xml ef478a3 > > Diff: https://reviews.apache.org/r/7204/diff/ > > > Testing > ------- > > One test class, AttachIsoCommand.java, with one test case against getVmName() > method of api/src/com/cloud/agent/api/AttachIsoCommand class. > > > USLT-205731:unittest yichi.lu$ pwd > /Users/yichi.lu/CloudStack/incubator-cloudstack/api/unittest > USLT-205731:unittest yichi.lu$ mvn test > [INFO] Scanning for projects... > [INFO] > [INFO] > ------------------------------------------------------------------------ > [INFO] Building Apache CloudStack API Unittest 4.0.0-SNAPSHOT > [INFO] > ------------------------------------------------------------------------ > [INFO] > [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ > cloud-api-unittest --- > [debug] execute contextualize > [INFO] Using 'UTF-8' encoding to copy filtered resources. > [INFO] skip non existing resourceDirectory > /Users/yichi.lu/CloudStack/incubator-cloudstack/api/unittest/src/main/resources > [INFO] > [INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ > cloud-api-unittest --- > [INFO] Compiling 221 source files to > /Users/yichi.lu/CloudStack/incubator-cloudstack/api/unittest/target/classes > [INFO] > [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ > cloud-api-unittest --- > [debug] execute contextualize > [INFO] Using 'UTF-8' encoding to copy filtered resources. > [INFO] Copying 0 resource > [INFO] > [INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ > cloud-api-unittest --- > [INFO] Compiling 1 source file to > /Users/yichi.lu/CloudStack/incubator-cloudstack/api/unittest/src/com/cloud/agent/api > [INFO] > [INFO] --- maven-surefire-plugin:2.10:test (default-test) @ > cloud-api-unittest --- > [INFO] Surefire report directory: > /Users/yichi.lu/CloudStack/incubator-cloudstack/api/unittest/target/surefire-reports > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Running com.cloud.agent.api.AttachIsoCommandTest > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.097 sec > > Results : > > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 7.546s > [INFO] Finished at: Thu Sep 20 22:31:38 CDT 2012 > [INFO] Final Memory: 11M/554M > [INFO] > ------------------------------------------------------------------------ > U > > > Thanks, > > Yichi Lu >