----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7192/#review11753 -----------------------------------------------------------
Especially for bugs not for 4.0. Please detail what was tested. Just simply stating tested doesn't do anything. - Alex Huang On Sept. 20, 2012, 1:25 p.m., Vijay Venkatachalam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7192/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2012, 1:25 p.m.) > > > Review request for cloudstack. > > > Description > ------- > > All 4 bugs together have minimal code changes; submitting them together. > > Bug: CS-15931 Delete Vm group not removing configs from NS. > Change: Checked for VM Groups current state before removal from NS. > Bug: CS-15935 NetScaler sessions increase in case of errors in the NetScaler > Change: Added logout before login. > Bug: CS-15930 Save config not triggered to NS after create, update delete VM > group > Change: Saveconfiguration triggered after successful NS API calls. > Bug: CS-15934 Handling Resource Unavailable exception for AutoScale > Change: If ResourceUnavailableException is caught, the state is reverted. > > PS: > I sincerely hope i have not made any spacing errors. > > > This addresses bugs CS-15930, CS-15931, CS-15934, and CS-15935. > > > Diffs > ----- > > api/src/com/cloud/agent/api/to/LoadBalancerTO.java 884c7c5 > api/src/com/cloud/network/as/AutoScaleService.java ef99512 > api/src/com/cloud/network/lb/LoadBalancingRule.java 5c39f31 > > plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java > f2a5278 > server/src/com/cloud/network/as/AutoScaleManagerImpl.java 0e5e81b > server/src/com/cloud/network/lb/LoadBalancingRulesManager.java ebe4e2a > server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 025e441 > > Diff: https://reviews.apache.org/r/7192/diff/ > > > Testing > ------- > > Build Successful > Test Successful > > > Thanks, > > Vijay Venkatachalam > >
