----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7040/ -----------------------------------------------------------
Review request for cloudstack. Description ------- Issue: System VMs on KVM create a patch disk on startup that contains a few file updates. These patch disks don't ever get cleaned up, causing them to build up. Fix: Make patch disk name non-unique and based on system vm so we never have more than one per system vm. On startup, look for existing patch disk with the correct name and use it, otherwise create a new one. Delete patch disk on shutdown (this cleans them up when VMs are destroyed as well). Hopefully I've unraveled the StorageManager/StorageAdaptor/LibvirtComputingResource correctly and created a proper implementation. Diffs ----- plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 53e6da7 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java 751da83 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java 9f62ee8 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/StorageAdaptor.java be6c5c0 Diff: https://reviews.apache.org/r/7040/diff/ Testing ------- Tested against current 4.0 branch, started/stopped routers for isolated and VPC networks and secondary storage VMs. Reboots continue to use existing patch disk, anything that stops the VM removes the patch disk. Thanks, Marcus Sorensen
