----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5655/#review11135 -----------------------------------------------------------
It shouldn't use the hardcoded string but the Config.XenCheckHvm. Please correct that. Leaving it in the DB is fine. - Alex Huang On June 29, 2012, 6:52 a.m., Hugo Trippaers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5655/ > ----------------------------------------------------------- > > (Updated June 29, 2012, 6:52 a.m.) > > > Review request for cloudstack. > > > Description > ------- > > Make xen.check.hvm a proper parameter in config.java and set the default to > false > > > Diffs > ----- > > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java > 4fd202b > server/src/com/cloud/configuration/Config.java 8936544 > > Diff: https://reviews.apache.org/r/5655/diff/ > > > Testing > ------- > > Simple build > clean-all build-all > > > Thanks, > > Hugo Trippaers > >
