+1 Darren any thoughts on the next step? Would be nice to integrate further with waf etc.
Cheers, Hugo -----Original Message----- From: Kelven Yang [mailto:kelven.y...@citrix.com] Sent: Thursday, August 23, 2012 11:37 PM To: cloudstack-dev@incubator.apache.org Subject: Re: maven patch I got Darren's maven patch work nicely in my local environment. Just to be cautious, I pushed it to ASF/maven branch for review first. If I don't hear no no's by tomorrow, I'll push it to master. After this patch, ant build and maven build will work side by side, this will give us a graceful period to have everyone migrate to maven based build system. If you use Eclipse, you will need to re-import all maven eclipse projects Kelven On 8/23/12 1:44 PM, "David Nalley" <da...@gnsa.us> wrote: >On Thu, Aug 23, 2012 at 11:20 AM, Darren Shepherd <dar...@godaddy.com> >wrote: >> Some Committer, >> >> I can't seem to get the maven patch to work through Review Board. >> Can a committer just pull the "maven" branch from >> https://github.com/ibuildthecloud/incubator-cloudstack.git merge to >> master and commit? One of the problems with the patch is that it >> moves deps/XenServerJava/com to deps/XenServerJava/src/com. With a >> patch that shows as a delete and add, not a move. Besides moving >> that directory the patch is non-impacting in that it just adds the >> pom.xml files everywhere. The summary of the diff will show that its >> just a bunch of adds. >> >> Darren > > >Merge request against the github mirror should work as well, and is >likely less work. > >--David