65c90227ae652f946f095167061035fb443ecb73 has a reviewed-by in the checkin.
It still did not explain how the bug was unit-tested. I think license header changes will be exempted but code changes I will not pick over until someone has explained what testing was performed. --Alex > -----Original Message----- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Wednesday, August 15, 2012 2:19 PM > To: cloudstack-dev@incubator.apache.org > Cc: Brian Federle > Subject: Re: [ASFCS40]merges to 4.0 > > On Wed, Aug 15, 2012 at 5:17 PM, Alex Huang <alex.hu...@citrix.com> > wrote: > > I have now redo all the merges. The merges are now up to commit > e1bfcdc1be30e363d1a072af5d39374a710cbc65. > > > > This time dc07b2e3e616d6f945b8e85756c9f3a4f72b2fec went fine so no > work from Brian needed. > > > > For quite a few of the checkins, I see no reviewer on the checkin > comments. I reviewed them this time. > > > > From now on, all checkins that go into 4.0 branch will need reviewer and > comments about how it was tested. > > > > --Alex > > That sounds very logical. Is there a good example commit you can point us all > to, showing everything you'd like to see? > > -chip
