----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6523/#review10196 -----------------------------------------------------------
api/src/com/cloud/api/commands/ListDiskOfferingsCmd.java <https://reviews.apache.org/r/6523/#comment21619> This is not going to solve the problem everywhere. This disk offering can be used during deploy vm or create volume command and you are not restricting him there using API. I think before we go down any path to solve the issue its important to list all the solutions possible with their pros and cons and then take one which seems the most appropriate. - Nitin Mehta On Aug. 10, 2012, 1:58 p.m., Rohit Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6523/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2012, 1:58 p.m.) > > > Review request for cloudstack and Nitin Mehta. > > > Description > ------- > > Bugfix: CS-14926 Do not show default custom disk offering > > Fixes CS-14926 by not sending default Custom disk offering in API response > Without disk offering info client won't be able to use this information. > > Admin can create new disk offering with custom disk size enabled, if such > a > disk offering is needed. > > Follow discussion on: http://bugs.cloudstack.org/browse/CS-14926 > > Download original patch: http://patchbin.baagi.org/p?id=aoqfqk > > > Diffs > ----- > > api/src/com/cloud/api/commands/ListDiskOfferingsCmd.java fbf655d > > Diff: https://reviews.apache.org/r/6523/diff/ > > > Testing > ------- > > Works for me! > > > Thanks, > > Rohit Yadav > >
