----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6558/#review10180 -----------------------------------------------------------
It would be slightly cleaner if instead of changing the method signatures from Set<Long> to TreeSet<Long> you instead used SortedSet<Long> - Darren Shepherd On Aug. 12, 2012, 4:09 p.m., mice xia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6558/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2012, 4:09 p.m.) > > > Review request for cloudstack and Alex Huang. > > > Description > ------- > > unittest NetUtilsTest failed sometimes because NetUtils.getRandomIpFromCidr's > return is non-deterministic > > fix NetUtils.getRandomIpFromCidr by rewriting it: > 1) remove network addr, broadcast addr, and startIp from Ip 'range' > 2) solve non-deterministic issue by ensuring return a result if avoid.size() > < range > > > Diffs > ----- > > server/src/com/cloud/network/guru/GuestNetworkGuru.java cd5f551 > utils/src/com/cloud/utils/net/NetUtils.java 886f441 > utils/test/com/cloud/utils/net/NetUtilsTest.java 345f1d9 > > Diff: https://reviews.apache.org/r/6558/diff/ > > > Testing > ------- > > pass unittest > > > Thanks, > > mice xia > >
