> On Aug. 12, 2012, 11:16 a.m., Nitin Mehta wrote: > > Ship It!
though the logging will log id's instead of uuids - Nitin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6337/#review10177 ----------------------------------------------------------- On Aug. 8, 2012, 11:09 a.m., Koushik Das wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6337/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2012, 11:09 a.m.) > > > Review request for cloudstack, Prachi Damle and Nitin Mehta. > > > Description > ------- > > Using migrateVolumes method which does not perform input validation. Some > input validation in the migrateVolume method prevented migration of volume in > READY state. Also using volume disk offering to check if it is a local or > shared one. > > > Diffs > ----- > > server/src/com/cloud/storage/StorageManagerImpl.java a2ea98d > > Diff: https://reviews.apache.org/r/6337/diff/ > > > Testing > ------- > > Verified on XS 6.0.2 > > Test scenario > - Created 2 shared primary storage pools > - Created data volume using shared disk offering > - Attached it to a running VM (created in one storage pool) > - Detached it (now it is in READY state) > - Created a new VM in stopped state (using deployVirtualMachine API with > startVm=false) > - Attached the data volume to this new VM > - Started new VM (migrated volume scenario got hit when the planner assigned > the other shared pool) > > > Thanks, > > Koushik Das > >
