----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6276/#review9681 -----------------------------------------------------------
1. Would it not be better to inform the admin of the current resource count? So he can take corrective action. Something like : "" Cannot update the resource limit to <given count>. There are <current count> type of resources in use. "" 2. Will this be applicable to domain-admins changing the limits for an account under that domain? Looks like it would. Just wanted to confirm. - Prasanna Santhanam On Aug. 1, 2012, 8:07 a.m., deepti dohare wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6276/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2012, 8:07 a.m.) > > > Review request for cloudstack. > > > Description > ------- > > If an account already has 2 resources (eg. 2 instances) and root admin > decreases that limit to 1, the limit is updated as 1 whereas it has to be > discarded. > The fix checks for the current resource count. > > > This addresses bug CS-15395. > > > Diffs > ----- > > server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java b285d2c > > Diff: https://reviews.apache.org/r/6276/diff/ > > > Testing > ------- > > Verified locally. > > > Thanks, > > deepti dohare > >
