Pranav: A couple of issues:
The commit contained an author statement, this is generally bad form, and unmaintainable. Moreover, the git log should show who the author is. (and I just saw a commit fixing that, thanks for taking care of it.) But this also suggests that the author isn't you, and I don't recall having seen this come through as a patch request. We have a processes for getting code into CloudStack and none of them involve a non-transparent back channel. This does a disservice to the original author (people aren't seeing patches from him, which impedes his path to becoming a committer) as well as casting doubts over the provenance of the code. All three of the commits appear to have authors that aren't you, did this code come in as a patch to the mailing list, reviews.a.o, or the bug tracker? --David > +/** > + * @author Deepak Garg > + */ > +
