----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6028/ -----------------------------------------------------------
Review request for cloudstack, Prachi Damle and Nitin Mehta. Description ------- fix CS-15609 Volumes can be created as a part of VM creation when un-allocated space is insufficient on primary storage check the availability of un-allocated primary storage space during planning stage, for multiple-volume VM creation scenario modification in findPotentialDeploymentResources: for each <volume, storagePool>, test if ( requestedVolumeSize + storagePool.usedCapacity > storagePool.totalCapacity * overprovisioningFactor * allocatedStorageThredshold This addresses bug CS-15609. Diffs ----- server/src/com/cloud/deploy/FirstFitPlanner.java eb82c75 Diff: https://reviews.apache.org/r/6028/diff/ Testing ------- perform following tests: (overprovisioning.factor=1) 1) create vm with 20G root + 20G data on one NFS PS, with allocation state 7.82GB/36.72GB, VM creation failed as expected 2) create vm with 20G root + 5G data on one NFS PS, with allocation state 7.82GB/36.72GB, threshold=0.85, VM creation failed as expected 3) create vm with 20G root + 5G data on one NFS PS, with allocation state 7.82GB/36.72GB, threshold=0.99, VM creation succeed as expected Thanks, mice xia
