----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5909/#review9099 -----------------------------------------------------------
1) Implementation for filters tag-key and tag-value are good. 2) But the filter tag:key need not be applied on top of the CloudStack list command's response like other filters. CloudStack List API has been updated to accept tag key:value filter. So we can set the key and value provided in the EC2 tag:key=value filter to the CloudStack API and get filtered results from CS. When EC2 filter is tag:region=canada, CloudStack command should be set this way: http://localhost:8096/?command=listVolumes&listAll=true&tags[0].key=region&tags[0].value=canada - Prachi Damle On July 11, 2012, 1:20 p.m., Likitha Shetty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5909/ > ----------------------------------------------------------- > > (Updated July 11, 2012, 1:20 p.m.) > > > Review request for cloudstack and Prachi Damle. > > > Description > ------- > > Tags support has been added to 3 EC2Describe* API's(DescribeInstances, > DescribeVolumes and DescribeSnapshots). Hence for the same 3 EC2Describe* > API's filter support has been modified to included 3 tag related filters: > tag-key, tag-value and tag:key. > > > Diffs > ----- > > awsapi/src/com/cloud/bridge/service/core/ec2/EC2InstanceFilterSet.java > 6d5255a > awsapi/src/com/cloud/bridge/service/core/ec2/EC2SnapshotFilterSet.java > 1c428f0 > awsapi/src/com/cloud/bridge/service/core/ec2/EC2VolumeFilterSet.java > 95d306f > > Diff: https://reviews.apache.org/r/5909/diff/ > > > Testing > ------- > > > Thanks, > > Likitha Shetty > >
