Please also correct the commit message. " When an instance is created with data volume, disk offering is not taken into account while checking the account limit. Adding a check for the diskoffering" It should instead say something like this - " When an instance is created with data volume, account limit for this data volume was not checked against. Adding a check for that"
Thanks, -Nitin -----Original Message----- From: Nitin Mehta [mailto:nore...@reviews.apache.org] On Behalf Of Nitin Mehta Sent: Saturday, July 07, 2012 1:23 AM To: cloudstack; Deepti Dohare; Nitin Mehta Subject: Re: Review Request: CS-15429: Create Instance should fail if creating instance results in exceeding volume resource limit for domain-admin or user accounts. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5766/#review8928 ----------------------------------------------------------- server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/5766/#comment18976> Please check this - In case the vm is booted from an iso then as well the disk offering is not null and refers to the the root disk offering and not to the data disk offering. - Nitin Mehta On July 5, 2012, 6:22 a.m., deepti dohare wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5766/ > ----------------------------------------------------------- > > (Updated July 5, 2012, 6:22 a.m.) > > > Review request for cloudstack. > > > Description > ------- > > When an instance is created with data volume, disk offering is not > taken into account while checking the account limit. Adding a check > for the diskoffering > > > This addresses bug CS-15429. > > > Diffs > ----- > > server/src/com/cloud/vm/UserVmManagerImpl.java d81ed7d > > Diff: https://reviews.apache.org/r/5766/diff/ > > > Testing > ------- > > Steps: > 1. create domains /ROOT/d1 + domain-admin account d1domain /ROOT/d2 + > user account d2user 2. login admin, set all resource limits for > d1domain to be 2, set all resource limits for d2user to be 3 3. login > d1domain, create VM 1 with no data volume: succeeded, create VM 2 with data > volume, Failed. Error message: Maximum number of resources of type 'volume' > for account name=d1domain in domain id=2 has been exceeded. > 4. login d2user, create VM 1 and VM2 both with no data volume: succeeded, > create VM 3 with data volume:failed, > Error message: "Maximum number of resources of type 'volume' for account > name=d2user in domain id=3 has been exceeded" > > > Thanks, > > deepti dohare > >
