Koushik, I reviewed the fix, it's not correct. We can't just put "if not null" checks, we have to figure out why network assigned to the IP Address is Removed.
When network is getting removed, all ip addresses associated with it have to be released. If you see ip left around, then it's a bug in network removal procedure. We have to fix the root cause instead of covering its symptoms with not null check later on. Please revert your commit a8c1568b3757bb71dc0a9d087b98ac922e6c629c and see if you can reproduce/fix the bug in network removal flow. BTW, you said it's related to VPC, but there was no VPC creation in the steps to reproduce? Thank you, Alena. On 7/3/12 11:31 PM, "Koushik Das" <koushik....@citrix.com> wrote: > > > > > > > > > > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5739/ > > > > > > Review request for cloudstack, Abhinandan Prateek and Alena Prokharchyk. >By Koushik Das. >Description > > > > During account cleanup, associated network is accessed without >checking whether it is present or not. Added a check to use it only when >present. > > Testing > > > Yes > > > Bugs: > >CS-15345 > > >Diffs > > >* server/src/com/cloud/network/NetworkManagerImpl.java (1e677a0) > >View Diff <https://reviews.apache.org/r/5739/diff/> > > > > > > > > > > > > > > >
