----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5762/#review8877 -----------------------------------------------------------
The 'else' condition checks for (info == null) but info is getting used inside the block. This will result NP exception. - Koushik Das On July 4, 2012, 6:27 p.m., Pranav Saxena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5762/ > ----------------------------------------------------------- > > (Updated July 4, 2012, 6:27 p.m.) > > > Review request for cloudstack and Abhinandan Prateek. > > > Description > ------- > > > 1) Have just 1 xen host. > 2) Have user VMs running on the backend. > 3) Issue Stop command and allow it to reach the backend but stop MS before > answer comes back > 4) start the management server. > > VM is stuck in Stopping state after restarting the management server > > > This addresses bug CS-13376. > > > Diffs > ----- > > server/src/com/cloud/vm/VirtualMachineManagerImpl.java > 561e5b290c8bf5e9e319e3588535041426530c5f > > Diff: https://reviews.apache.org/r/5762/diff/ > > > Testing > ------- > > Debugged the code by putting system.exit statements to track the response > from the backend and thereby tested it on my local cloudstack set up. > > > Thanks, > > Pranav Saxena > >
