Applied.
> -----Original Message----- > From: Pradeep Soundararajan [mailto:pradeep.soundarara...@citrix.com] > Sent: Thursday, June 21, 2012 8:43 AM > To: cloudstack-dev@incubator.apache.org > Subject: RE: Moving third party dependencies to ASF approved licenses - > jnetpcap > > Please help to apply the patch from > http://bugs.cloudstack.org/browse/CS-15309 > > You can see the test results from this ticket... > > Let me know if you have any questions. > > Thanks, > Pradeep.S > > > -----Original Message----- > From: Pradeep Soundararajan [mailto:pradeep.soundarara...@citrix.com] > Sent: Monday, June 18, 2012 12:33 PM > To: cloudstack-dev@incubator.apache.org > Subject: RE: Moving third party dependencies to ASF approved licenses - > jnetpcap > > Thanks Edison and David. My build is successful now. > > I hope the first one JnetPcap can be removed now. > > Please review the patch which is attached and we can submit the same to > ASF to commit.... > > Thanks, > Pradeep.S > > > -----Original Message----- > From: Edison Su [mailto:edison...@citrix.com] > Sent: Friday, June 15, 2012 11:46 PM > To: cloudstack-dev@incubator.apache.org > Subject: RE: Moving third party dependencies to ASF approved licenses - > jnetpcap > > > > > -----Original Message----- > > From: David Nalley [mailto:da...@gnsa.us] > > Sent: Friday, June 15, 2012 11:00 AM > > To: cloudstack-dev@incubator.apache.org > > Subject: Re: Moving third party dependencies to ASF approved licenses > > - jnetpcap > > > > On Fri, Jun 15, 2012 at 1:38 PM, Edison Su <edison...@citrix.com> > wrote: > > > > > > > > >> -----Original Message----- > > >> From: David Nalley [mailto:da...@gnsa.us] > > >> Sent: Friday, June 15, 2012 10:36 AM > > >> To: cloudstack-dev@incubator.apache.org > > >> Subject: Re: Moving third party dependencies to ASF approved > > licenses - > > >> jnetpcap > > >> > > >> On Fri, Jun 15, 2012 at 1:32 PM, Pradeep Soundararajan > > >> <pradeep.soundarara...@citrix.com> wrote: > > >> > Hi Edison, > > >> > > > >> > It looks like some other codes are also dependent on this code, > I > > >> have got some other compilation error after removing these codes > > >> and the jar. > > >> > > > >> > Error: > > >> > compile-agent: > > >> > [mkdir] Created dir: /home/pradeep/workspaces/cloudstack- > > >> oss/target/classes/cloud-agent.jar > > >> > [echo] Compiling /home/pradeep/workspaces/cloudstack- > > >> oss/agent/src > > >> > [javac] Compiling 41 source files to > > >> /home/pradeep/workspaces/cloudstack-oss/target/classes/cloud- > > agent.jar > > >> > [javac] /home/pradeep/workspaces/cloudstack- > > >> > > > oss/agent/src/com/cloud/agent/resource/computing/CloudZonesComputingRe > > s > > >> ource.java:42: cannot find symbol > > >> > [javac] symbol : class DhcpSnooperImpl > > >> > [javac] location: package com.cloud.agent.dhcp > > >> > [javac] import com.cloud.agent.dhcp.DhcpSnooperImpl; > > >> > [javac] ^ > > >> > [javac] /home/pradeep/workspaces/cloudstack- > > >> > > > oss/agent/src/com/cloud/agent/resource/computing/CloudZonesComputingRe > > s > > >> ource.java:75: cannot find symbol > > >> > [javac] symbol : class DhcpSnooperImpl > > >> > [javac] location: class > > >> com.cloud.agent.resource.computing.CloudZonesComputingResource > > >> > [javac] _dhcpSnooper = new > > DhcpSnooperImpl(bridgeName, > > >> _dhcpTimeout); > > >> > [javac] ^ > > >> > [javac] Note: /home/pradeep/workspaces/cloudstack- > > >> oss/agent/src/com/cloud/agent/resource/computing/LibvirtVMDef.java > > uses > > >> unchecked or unsafe operations. > > >> > [javac] Note: Recompile with -Xlint:unchecked for details. > > >> > [javac] 2 errors > > >> > > > >> > > > >> > Thanks, > > >> > Pradeep.S > > >> > > >> I fully expect that you'll have to look for and modify the places > > that > > >> try an import those classes in addition to just removing the files. > > > > > > CloudZonesComputingResource can be removed also. > > > > > > Is CloudZones completely deprecated? I thought that was going to > allow > > us to do interesting federated things ala MyCloud > MyCloud will use that DHCP snooping stuff, and currently doesn't work > on 3.0.x and master branch(the change in mgt server breaks mycloud). So > it's OK to be removed right now, if we want this feature in the future, > we can add it back. > > > > > --David
