Olga, I have verified and merged in your patches to ASF master, for the following UI bugs:
http://bugs.cloudstack.org/browse/CS-14010 http://bugs.cloudstack.org/browse/CS-14230 Thanks, Brian From: Pranav Saxena <pranav.sax...@citrix.com<mailto:pranav.sax...@citrix.com>> Date: Wed, 13 Jun 2012 03:30:00 -0700 To: "Olga Smola (olya.sm...@gmail.com<mailto:olya.sm...@gmail.com>)" <olya.sm...@gmail.com<mailto:olya.sm...@gmail.com>> Cc: "cloudstack-us...@incubator.apache.org<mailto:cloudstack-us...@incubator.apache.org>" <cloudstack-us...@incubator.apache.org<mailto:cloudstack-us...@incubator.apache.org>>, Jessica Wang <jessica.w...@citrix.com<mailto:jessica.w...@citrix.com>>, Brian Federle <brian.fede...@citrix.com<mailto:brian.fede...@citrix.com>>, Will Chan <will.c...@citrix.com<mailto:will.c...@citrix.com>>, David Nalley <da...@gnsa.us<mailto:da...@gnsa.us>> Subject: RE: CloudStack bugs, CS-14896 No problems Olga. Feel free to check in your patches. Regards, Pranav From: Olga Smola [mailto:olya.sm...@gmail.com] Sent: Wednesday, June 13, 2012 3:57 PM To: Pranav Saxena Subject: Re: CloudStack bugs, CS-14896 Pranav, thank you. On Wed, Jun 13, 2012 at 1:22 PM, Pranav Saxena <pranav.sax...@citrix.com<mailto:pranav.sax...@citrix.com>> wrote: Hi Olga , Your patch looks perfect . The code looks similar to the diff file you had attached yesterday apart from few extra curly braces which are present in the patch now . Actually I had myself put those extra curly braces at appropriate places (which were missing in the diff file)to verify your code changes. I’ll ask Brian /Jessica to merge your patch. Thanks & Regards, Pranav From: Olga Smola [mailto:olya.sm...@gmail.com<mailto:olya.sm...@gmail.com>] Sent: Wednesday, June 13, 2012 3:31 PM To: Pranav Saxena Cc: Jessica Wang; cloudstack-us...@incubator.apache.org<mailto:cloudstack-us...@incubator.apache.org>; David Nalley (da...@gnsa.us<mailto:da...@gnsa.us>); Brian Federle; Sonny Chhen; Will Chan Subject: Re: CloudStack bugs, CS-14896 Hi Pranav, I've just attached git patch to http://bugs.cloudstack.org/browse/CS-14230, could you please check if it's correct? Thanks, Olga. On Tue, Jun 12, 2012 at 10:33 PM, Pranav Saxena <pranav.sax...@citrix.com<mailto:pranav.sax...@citrix.com>> wrote: Hi Olga, I have reviewed your patch for this bug as well - http://bugs.cloudstack.org/browse/CS-14230 . This is what I have to say - 1) The patch looks good but since you had attached the diff file , there was misplacement of the curly braces which was making the situation a little tedious for us to put your patch at the appropriate places , eventually leading to unnecessary errors . So will it be possible for you to follow the git workflow instead of attaching diffs ? This would help us in reviewing your code more easily and would make the process even more faster. 2) Is it possible for you to make your own private branch ? ( I am not sure about this ) Otherwise , the patch is perfect and works absolutely fine . Good work !:) Thanks & Regards, Pranav -----Original Message----- From: Jessica Wang Sent: Tuesday, June 12, 2012 11:31 PM To: Pranav Saxena; Olga Smola (olya.sm...@gmail.com<mailto:olya.sm...@gmail.com>); cloudstack-us...@incubator.apache.org<mailto:cloudstack-us...@incubator.apache.org>; David Nalley (da...@gnsa.us<mailto:da...@gnsa.us>) Cc: Brian Federle; Sonny Chhen; Will Chan Subject: RE: CloudStack bugs, CS-14896 CS-14111 (There is no option to Edit IP ranges of Management Traffic) is invalid. I've written down my comment and close the bug as "By design". http://bugs.cloudstack.org/browse/CS-14111 -----Original Message----- From: Pranav Saxena Sent: Tuesday, June 12, 2012 9:39 AM To: Olga Smola (olya.sm...@gmail.com<mailto:olya.sm...@gmail.com>); cloudstack-us...@incubator.apache.org<mailto:cloudstack-us...@incubator.apache.org>; David Nalley (da...@gnsa.us<mailto:da...@gnsa.us>) Cc: Jessica Wang; Brian Federle; Sonny Chhen; Will Chan Subject: RE: CloudStack bugs, CS-14896 Hi Olga , I have reviewed the following bugs fixed by you and this is what I have found - 1) http://bugs.cloudstack.org/browse/CS-14511 - This bug seems to be already fixed in 3.0.3 release . Though your patch of code was perfect. 2) http://bugs.cloudstack.org/browse/CS-13535 - This patch of code works perfect. The bug was reproducible and the spinner never stopped once you created a child domain with the same name. (Brian you could verify it once more). 3) http://bugs.cloudstack.org/browse/CS-12478 - This has also been verified. The patch looks good according to me . The patches for the other bugs have already been merged or are getting reviwed. Thanks & Regards, Pranav -----Original Message----- From: David Nalley [mailto:da...@gnsa.us<mailto:da...@gnsa.us>] Sent: Tuesday, June 12, 2012 7:25 PM To: Pranav Saxena Cc: Jessica Wang; Brian Federle; Sonny Chhen; Will Chan Subject: Re: CloudStack bugs, CS-14896 Ohhh please do this! If you publicly review all of her existing patches I'll happily propose you as a committer. (and I'll happily take care of merges too should Jessica/Brian/Sonny not have issues with this process.) --David On Tue, Jun 12, 2012 at 9:43 AM, Pranav Saxena <pranav.sax...@citrix.com<mailto:pranav.sax...@citrix.com>> wrote: > Hi Olga, > > I am also a UI developer here. I have reviewed most of your diffs which you > have attached with the respective bug tickets and will look at the remaining > ones very soon .They look good to me. I 'll also ask Jessica /Brian ( Senior > UI developers here ) to merge your patches once they are also satisfied with > your code changes .In case there are any issues , they'll let you know > regarding any further modifications required. > > Thanks & Regards, > Pranav Saxena > > -----Original Message----- > From: Nitin Mehta > [mailto:nitin.me...@citrix.com<mailto:nitin.me...@citrix.com>] > Sent: Tuesday, June 12, 2012 5:40 PM > To: Olga Smola; > cloudstack-dev@incubator.apache.org<mailto:cloudstack-dev@incubator.apache.org>; > Jessica Wang > Subject: RE: CloudStack bugs, CS-14896 > > This is good work Olga. Were you able to subscribe to the lists I > forwarded you below ? If not, I advise you to do so asap. There is a > way for you to submit your work in form of patches. Refer to the wiki > http://wiki.cloudstack.org/display/dev/Git+workflow+in+the+brave+new+w > orld#Gitworkflowinthebravenewworld-Non-committerworkflow > I am copying you on the dev list to get you going and Jessica is the > maintainer of the UI component so she should be able to help review your work > but, you need to follow the procedure in the wiki above to submit your work. > Also once again I request you to subscribe to the Distribution lists below. > > > Thanks, > -Nitin > > From: Olga Smola [mailto:olya.sm...@gmail.com<mailto:olya.sm...@gmail.com>] > Sent: Tuesday, June 12, 2012 4:09 PM > To: Nitin Mehta > Subject: Re: CloudStack bugs, CS-14896 > > Hi Nitin, > > could you please help me to ask somebody to review the tickets I've already > completed? > I've started to work on CloudStack bugs a week ago and I have solutions for: > http://bugs.cloudstack.org/browse/CS-14511 > http://bugs.cloudstack.org/browse/CS-13535 > http://bugs.cloudstack.org/browse/CS-14111 > http://bugs.cloudstack.org/browse/CS-14010 (was reviewed yesterday) > http://bugs.cloudstack.org/browse/CS-12478 > http://bugs.cloudstack.org/browse/CS-14230 > http://bugs.cloudstack.org/browse/CS-14896 > and now I'm working on http://bugs.cloudstack.org/browse/CS-4460. > > I can spend some time to work on CloudStack, so if there is actual UI ticket, > I can work on it. But I don't know to whom should I write to get a feedback. > > Best regards, Olga. > On Mon, Jun 11, 2012 at 3:35 PM, Olga Smola > <olya.sm...@gmail.com<mailto:olya.sm...@gmail.com><mailto:olya.sm...@gmail.com<mailto:olya.sm...@gmail.com>>> > wrote: > Nitin, > > thanks, I'll write to you if any problems. Have a good day! > > On Mon, Jun 11, 2012 at 1:58 PM, Nitin Mehta > <nitin.me...@citrix.com<mailto:nitin.me...@citrix.com><mailto:nitin.me...@citrix.com<mailto:nitin.me...@citrix.com>>> > wrote: > Olga - Please do let me know in case you have a problem catching > somebody to review your code > > From: Olga Smola > [mailto:olya.sm...@gmail.com<mailto:olya.sm...@gmail.com><mailto:olya.sm...@gmail.com<mailto:olya.sm...@gmail.com>>] > Sent: Monday, June 11, 2012 4:26 PM > To: Nitin Mehta > Subject: Re: CloudStack bugs, CS-14896 > > Hi Nitin, > > thanks a lot. > On Mon, Jun 11, 2012 at 12:45 PM, Nitin Mehta > <nitin.me...@citrix.com<mailto:nitin.me...@citrix.com><mailto:nitin.me...@citrix.com<mailto:nitin.me...@citrix.com>>> > wrote: > Olga - This is superb. Since CS has been donated to Apache Server foundation > now you can more easily contribute your code (initially as patch) and become > a committer. > I would suggest you to subscribe to the following lists to get going. > > cloudstack-commits-subscr...@incubator.apache.org<mailto:cloudstack-commits-subscr...@incubator.apache.org><mailto:cloudstack-co<mailto:cloudstack-co> > mmits-subscr...@incubator.apache.org<mailto:mmits-subscr...@incubator.apache.org>> > cloudstack-dev-subscr...@incubator.apache.org<mailto:cloudstack-dev-subscr...@incubator.apache.org><mailto:cloudstack-dev-su<mailto:cloudstack-dev-su> > bscr...@incubator.apache.org<mailto:bscr...@incubator.apache.org>> > cloudstack-users-subscr...@incubator.apache.org<mailto:cloudstack-users-subscr...@incubator.apache.org><mailto:cloudstack-user<mailto:cloudstack-user> > s-subscr...@incubator.apache.org<mailto:s-subscr...@incubator.apache.org>> > > Just send an email to them to subscribe. > > Refer to this for creating a patch > http://wiki.cloudstack.org/display/dev/Git+workflow+in+the+brave+new+w > orld#Gitworkflowinthebravenewworld-Non-committerworkflow > > > Thanks again, > -Nitin > > From: Olga Smola > [mailto:olya.sm...@gmail.com<mailto:olya.sm...@gmail.com><mailto:olya.sm...@gmail.com<mailto:olya.sm...@gmail.com>>] > Sent: Monday, June 11, 2012 2:59 PM > To: Nitin Mehta > Subject: CloudStack bugs, CS-14896 > > Hi Nitin, > > excuse me to bother you. My name is Olga, and I'm interested in work on > CloudStack. I'm UI developer and I can help to fix, extend project's UI. I > saw your post on http://bugs.cloudstack.org/browse/CS-14896 and I think that > my fix should help to you. Also I've fixed several other bugs > (http://bugs.cloudstack.org (http://bugs.cloudstack.org/browse/CS-14511, > http://bugs.cloudstack.org/browse/CS-13535, > http://bugs.cloudstack.org/browse/CS-14111), but I don't know how can I get > the feedback. Maybe you know whom can I write to review my fixes? > > Best regards, Olga Smola. > > >
