>> This inherently looks ok, but Paramiko that you use in the above patch >> is licensed LGPLv2 - and needs to be removed[1]. Before we perpetuate >> its use, would you take a look at: >> >> http://bugs.cloudstack.org/browse/CS-14998 >> http://bugs.cloudstack.org/browse/CS-14999 >> http://bugs.cloudstack.org/browse/CS-15001 >> http://bugs.cloudstack.org/browse/CS-15002 >> >> Since FWIU, the test client is the only place python-paramiko is >> currently used it should be simple to eradicate that and just add a >> dependency in the RPM/deb (or egg). > > Test client doesn't include the paramkio source code into its directory, the > migration tool(tools/migration) does. >
Thanks David for keeping a tight watch. We egg-ified the test client just before the move to ASF. [1] The python egg for marvin (test framework) does not package the paramiko library [2]. It only enforces it as a dependency for running the marvin test client. So I think we are okay. Also as Edison says we didn't package the library into our code base. Having said that - we do have some duplicate code lying around after the packaging of marvin. I will send in a separate patch for removing the duplicate code in tools/testClient. [1] http://bugs.cloudstack.org/browse/CS-14025 [2] Marvin packaging script: tools/marvin/setup.py -- Prasanna.,
