On Fri, May 18, 2012 at 3:09 AM, John Kinsella <j...@stratosec.co> wrote: > On May 17, 2012, at 10:57 PM, David Nalley wrote: >> On Thu, May 17, 2012 at 12:42 PM, John Kinsella <j...@stratosec.co> wrote: >>> I'd like to document the process for Apache CloudStack, as well...for this >>> one I sent a pull request to CloudStack on github, but I suspect that >>> process is going to change in the coming weeks... >> So a couple of comments. >> >> We can mirror our ASF repo to github, and accept patches to pull >> requests apparently. (For those I misinformed privately about this >> fact - I apologize - at the time I was unaware of github mirroring.) >> >> But I think we should also have patches sent to the list via git >> format-patch - and perhaps a few other ways. I am personally keen on >> preserving proper attribution in git log, so a diff isn't quite >> enough. > > Concur. How has that been working so far? Seems too easy for people to send a > pull request and just expect that's it, versus specifying that changes will > only be accepted via patches sent to the dev list or to the maintainers - I'm > thinking about how the Linux kernel does this, although that might be > overkill... >
Others experiences might vary, but from my personal reviewer/committer perspective, patches sent to the mailing list with git format-patch are super easy for me to deal with, and the pull requests from github are also easy - but not as easy. --David
