Great - thanks Alex! All the efforts around clojure.spec will definitely bring consistency in the world of Clojure codebases : )
On Friday, August 19, 2016 at 9:05:16 PM UTC-7, Alex Miller wrote: > > That looks like a bug in lein-cljsbuild. cljsbuild/crossover.clj is > failing due to (import java.io.File java.net.URLDecoder) - should be > (:import java.io.File java.net.URLDecoder). > > PR filed here: https://github.com/emezeske/lein-cljsbuild/pull/447 > > > > On Friday, August 19, 2016 at 9:55:17 PM UTC-5, Rangel Spasov wrote: >> >> Ran into this problem with ClojureScript/ReactNative/Re-natal project: >> >> Compiling ClojureScript... >> >> Exception in thread "main" java.lang.IllegalArgumentException: Call to >> clojure.core/ns did not conform to spec: >> >> In: [3 0] val: import fails spec: :clojure.core.specs/ns-refer-clojure >> at: [:args :clauses :refer-clojure :clause] predicate: #{:refer-clojure} >> >> In: [3 0] val: import fails spec: :clojure.core.specs/ns-require at: >> [:args :clauses :require :clause] predicate: #{:require} >> >> In: [3 0] val: import fails spec: :clojure.core.specs/ns-import at: >> [:args :clauses :import :clause] predicate: #{:import} >> >> In: [3 0] val: import fails spec: :clojure.core.specs/ns-use at: [:args >> :clauses :use :clause] predicate: #{:use} >> >> In: [3 0] val: import fails spec: :clojure.core.specs/ns-refer at: [:args >> :clauses :refer :clause] predicate: #{:refer} >> >> In: [3 0] val: import fails spec: :clojure.core.specs/ns-load at: [:args >> :clauses :load :clause] predicate: #{:load} >> >> In: [3 0] val: import fails spec: :clojure.core.specs/ns-gen-class at: >> [:args :clauses :gen-class :clause] predicate: #{:gen-class} >> >> :clojure.spec/args (cljsbuild.crossover (:use [clojure.java.io :only >> [as-url resource]]) (:require [cljsbuild.util :as util] [clojure.string :as >> string] [fs.core :as fs]) (import java.io.File java.net.URLDecoder)) >> >> , compiling:(cljsbuild/crossover.clj:1:1) >> >> at clojure.lang.Compiler.macroexpand1(Compiler.java:6795) >> >> at clojure.lang.Compiler.macroexpand(Compiler.java:6861) >> >> at clojure.lang.Compiler.eval(Compiler.java:6935) >> >> at clojure.lang.Compiler.load(Compiler.java:7403) >> >> at clojure.lang.RT.loadResourceScript(RT.java:374) >> >> at clojure.lang.RT.loadResourceScript(RT.java:365) >> >> at clojure.lang.RT.load(RT.java:455) >> >> at clojure.lang.RT.load(RT.java:421) >> >> at clojure.core$load$fn__7645.invoke(core.clj:6008) >> >> at clojure.core$load.invokeStatic(core.clj:6007) >> >> at clojure.core$load.doInvoke(core.clj:5991) >> >> at clojure.lang.RestFn.invoke(RestFn.java:408) >> >> at clojure.core$load_one.invokeStatic(core.clj:5812) >> >> at clojure.core$load_one.invoke(core.clj:5807) >> >> at clojure.core$load_lib$fn__7590.invoke(core.clj:5852) >> >> at clojure.core$load_lib.invokeStatic(core.clj:5851) >> >> at clojure.core$load_lib.doInvoke(core.clj:5832) >> >> at clojure.lang.RestFn.applyTo(RestFn.java:142) >> >> at clojure.core$apply.invokeStatic(core.clj:659) >> >> at clojure.core$load_libs.invokeStatic(core.clj:5889) >> >> at clojure.core$load_libs.doInvoke(core.clj:5873) >> >> at clojure.lang.RestFn.applyTo(RestFn.java:137) >> >> at clojure.core$apply.invokeStatic(core.clj:659) >> >> at clojure.core$require.invokeStatic(core.clj:5911) >> >> at clojure.core$require.doInvoke(core.clj:5911) >> >> at clojure.lang.RestFn.invoke(RestFn.java:436) >> >> at user$eval15.invokeStatic(form-init1217511081856523183.clj:1) >> >> at user$eval15.invoke(form-init1217511081856523183.clj:1) >> >> at clojure.lang.Compiler.eval(Compiler.java:6951) >> >> at clojure.lang.Compiler.eval(Compiler.java:6940) >> >> at clojure.lang.Compiler.load(Compiler.java:7403) >> >> at clojure.lang.Compiler.loadFile(Compiler.java:7341) >> >> at clojure.main$load_script.invokeStatic(main.clj:276) >> >> at clojure.main$init_opt.invokeStatic(main.clj:278) >> >> at clojure.main$init_opt.invoke(main.clj:278) >> >> at clojure.main$initialize.invokeStatic(main.clj:309) >> >> at clojure.main$null_opt.invokeStatic(main.clj:343) >> >> at clojure.main$null_opt.invoke(main.clj:340) >> >> at clojure.main$main.invokeStatic(main.clj:422) >> >> at clojure.main$main.doInvoke(main.clj:385) >> >> at clojure.lang.RestFn.applyTo(RestFn.java:137) >> >> at clojure.lang.Var.applyTo(Var.java:700) >> >> at clojure.main.main(main.java:37) >> >> Caused by: java.lang.IllegalArgumentException: Call to clojure.core/ns >> did not conform to spec: >> >> In: [3 0] val: import fails spec: :clojure.core.specs/ns-refer-clojure >> at: [:args :clauses :refer-clojure :clause] predicate: #{:refer-clojure} >> >> In: [3 0] val: import fails spec: :clojure.core.specs/ns-require at: >> [:args :clauses :require :clause] predicate: #{:require} >> >> In: [3 0] val: import fails spec: :clojure.core.specs/ns-import at: >> [:args :clauses :import :clause] predicate: #{:import} >> >> In: [3 0] val: import fails spec: :clojure.core.specs/ns-use at: [:args >> :clauses :use :clause] predicate: #{:use} >> >> In: [3 0] val: import fails spec: :clojure.core.specs/ns-refer at: [:args >> :clauses :refer :clause] predicate: #{:refer} >> >> In: [3 0] val: import fails spec: :clojure.core.specs/ns-load at: [:args >> :clauses :load :clause] predicate: #{:load} >> >> In: [3 0] val: import fails spec: :clojure.core.specs/ns-gen-class at: >> [:args :clauses :gen-class :clause] predicate: #{:gen-class} >> >> :clojure.spec/args (cljsbuild.crossover (:use [clojure.java.io :only >> [as-url resource]]) (:require [cljsbuild.util :as util] [clojure.string :as >> string] [fs.core :as fs]) (import java.io.File java.net.URLDecoder)) >> >> >> at clojure.spec$macroexpand_check.invokeStatic(spec.clj:627) >> >> at clojure.spec$macroexpand_check.invoke(spec.clj:616) >> >> at clojure.lang.AFn.applyToHelper(AFn.java:156) >> >> at clojure.lang.AFn.applyTo(AFn.java:144) >> >> at clojure.lang.Var.applyTo(Var.java:700) >> >> at clojure.lang.Compiler.macroexpand1(Compiler.java:6789) >> >> ... 42 more >> >> Error encountered performing task 'cljsbuild' with profile(s): 'prod' >> >> On Friday, August 19, 2016 at 11:35:31 AM UTC-7, Alex Miller wrote: >>> >>> One thing to note is that the new specs for clojure.core means that >>> there is a reasonable amount of (broken) code in the wild that now does not >>> compile. >>> >>> I have filed PRs in a number of commonly used projects and while those >>> were all merged, most have not yet been released into new versions yet. Any >>> project that uses any of those projects via dependencies will also have >>> issues. So, expect to see some breakage if using the latest alpha. In >>> particular, ClojureScript itself had a bad ns declaration through version >>> 1.9.93 so anything not on a fresh CLJS will likely see that. >>> >>> The three most common things I saw were: >>> >>> 1. (ns ... (require ...) (import ...) ) instead of (ns ... (:require >>> ...) (:import ...) ) >>> >>> 2. (fn a.b [] ...) - fully-qualified symbol names in fn (these are >>> pretty much always the result of a sloppy macro that expands to fn) >>> >>> 3. (let [{ ... :or {:a 1}} {}] ... ) - :or keys that are not simple >>> symbols. There were some accidental cases where this did something for >>> fully-qualified keyword keys in the past, but those were not intended and >>> are no longer accepted as of Clojure 1.9.0-alpha8. All of the cases I found >>> were actually typos though where the keyword was used instead of the symbol. >>> >>> >>> >>> >>> On Friday, August 19, 2016 at 1:15:06 PM UTC-5, Alex Miller wrote: >>>> >>>> Clojure 1.9.0-alpha11 is now available. >>>> >>>> Try it via >>>> >>>> - Download: >>>> https://repo1.maven.org/maven2/org/clojure/clojure/1.9.0-alpha11 >>>> - Leiningen: [org.clojure/clojure "1.9.0-alpha11"] >>>> >>>> 1.9.0-alpha11 includes the following changes since 1.9.0-alpha10: >>>> >>>> Clojure now has specs for the following clojure.core macros: let, >>>> if-let, when-let, defn, defn-, fn, and ns. Because macro specs are checked >>>> during macroexpansion invalid syntax in these macros will now fail at >>>> compile time whereas some errors were caught at runtime and some were not >>>> caught at all. >>>> >>>> - CLJ-1914 - Fixed race condition in concurrent range realization >>>> - CLJ-1870 - Fixed reloading a defmulti removes metadata on the var >>>> - CLJ-1744 - Clear unused locals, which can prevent memory leaks in >>>> some cases >>>> - CLJ-1423 - Allow vars to be invoked with infinite arglists (also, >>>> faster) >>>> - CLJ-1993 - Added *print-namespace-maps* dynamic var that controls >>>> whether to use namespace map syntax for maps with keys from the same >>>> namespace. The default is false, but standard REPL bindings set this to >>>> true. >>>> - CLJ-1985 - Fixed with-gen of conformer losing unform fn >>>> - Fixed clojure.spec.test/check to skip spec'ed macros >>>> - Fixed regression from 1.9.0-alpha8 where type hints within >>>> destructuring were lost >>>> - Fixed clojure.spec/merge docstring to note merge doesn't flow >>>> conformed values >>>> - Fixed regex ops to use gen overrides if they are used >>>> >>> -- You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com Note that posts from new members are moderated - please be patient with your first post. To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en --- You received this message because you are subscribed to the Google Groups "Clojure" group. To unsubscribe from this group and stop receiving emails from it, send an email to clojure+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
