I should mention, not all usages of c.string/replace will break :), but it does change the behaviour when using a function as the replacement value. You can see more details at CLJS-1304 <http://dev.clojure.org/jira/browse/CLJS-1304>.
On Wed, Oct 14, 2015 at 5:10 PM Daniel Compton < daniel.compton.li...@gmail.com> wrote: > Hi folks > > Just wanted to mention that "CLJS-1304: c.string/replace differs from > Clojure" is a breaking change. It was first introduced in 1.7.58, but that > was marked as pre-release, 1.7.145 is the first stable version with the > patch. It affected us through cljs-time > <https://github.com/andrewmcveigh/cljs-time/issues/43>. It's probably > worth checking any usages of string/replace in your code (and it's > dependencies?) still work as expected. > > On Wed, Oct 14, 2015 at 9:46 AM David Nolen <dnolen.li...@gmail.com> > wrote: > >> It's an innocuous warning from badly annotated code from the Google >> Closure Library. Annoying but not important. >> >> We'll probably cut a followup release with a bumped GCL dependency once >> it's clear there are not more pressing problems. >> >> David >> >> On Tue, Oct 13, 2015 at 3:58 PM, Nathan B <nate...@gmail.com> wrote: >> >>> On Tuesday, October 13, 2015 at 8:02:07 AM UTC-7, David Nolen wrote: >>> > ClojureScript, the Clojure compiler that emits JavaScript source code. >>> > >>> > >>> > README and source code: https://github.com/clojure/clojurescript >>> > >>> > >>> > Leiningen dependency information: >>> > >>> > >>> > [org.clojure/clojurescript "1.7.145"] >>> > >>> > >>> > This release updates the Google Closure Compiler dependency and >>> > includes many small enhancements and fixes. >>> > >>> > >>> > As always feedback welcome! >>> > >>> > >>> > ## 1.7.145 >>> > >>> > >>> > ### Enhancements >>> > * CLJS-1455: high resoluting timing where available >>> > * CLJS-1403: Add updated Windows shell scripts >>> > * CLJS-1017: support :main for :advanced and :simple builds >>> > * CLJS-1409: allow basic type checking of protocols >>> > * CLJS-1404: var resolution for @param and @return >>> > * CLJS-1395: Node.js REPL debug port support >>> > >>> > >>> > ### Changes >>> > * CLJS-1464: docstrings for transducer arities >>> > * Latest Google Closure Compiler dependency >>> > * Node.js REPL sets *target* >>> > * add cljs.analyzer.api/get-js-index >>> > * add goog.object to list of implicit namespaces >>> > * CLJS-1393: turn *target* into goog-define >>> > >>> > >>> > ### Fixes >>> > * UUID hashing >>> > * CLJS-1465: fix *main-cli-fn* doc >>> > * CLJS-1456: bad require forms at REPL can corrupt REPL session >>> > * CLJS-1449: self host :require-macros bug >>> > * CLJS-1462: self host regression >>> > * Add header bits for Node.js under :none >>> > * CLJS-1457: unicode symbol munging >>> > * CLJS-1442: self host, docstring typos >>> > * CLJS-1441: portable clojure.string >>> > * CLJS-1436: self-host, dep ns not loaded >>> > * CLJS-1440: self-host, eval support in Web Workers >>> > * CLJS-1400: self-host, doseq broken >>> > * CLJS-1435: self-host, bad lexical scope >>> > * CLJS-1434: clojure.walk no longer preseves meta >>> > * CLJS-1432: '$ and '. symbol collision under advanced >>> > * CLJS-1304: c.string/replace differs from Clojure >>> > * CLJS-1430: bad code gen for self host .toString method calls >>> > * CLJS-1353: range inconsistent with Clojure >>> > * CLJS-1431: load-file doc output missing arglists >>> > * CLJS-1433: cljs.js/*eval-fn* passed nil :cache >>> > * CLJS-1299: add more support for literals to cljs.reader >>> > * CLJS-1417: cljs.js require macros failures >>> > * CLJS-1416: cljs.util/last-modified leaks files >>> > * CLJS-1481: self host defprotocol regression >>> > * CLJS-1414: only munge @param & @return if type checking >>> > * CLJS-1401: unify runtime & compile UUID hashing >>> > * CLJS-1395: no trailing semicolons after JS comment >>> > * CLJS-1394: reify gensyms can clash >>> >>> When I compile in advanced mode, I am getting the following warning: >>> >>> WARNING - Parse error. unknown @suppress parameter: >>> checkStructDictInheritance >>> >> * @suppress {checkStructDictInheritance} >>> >>> -- >>> Note that posts from new members are moderated - please be patient with >>> your first post. >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "ClojureScript" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to clojurescript+unsubscr...@googlegroups.com. >>> To post to this group, send email to clojurescr...@googlegroups.com. >>> Visit this group at http://groups.google.com/group/clojurescript. >>> >> >> -- >> Note that posts from new members are moderated - please be patient with >> your first post. >> --- >> You received this message because you are subscribed to the Google Groups >> "ClojureScript" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to clojurescript+unsubscr...@googlegroups.com. >> To post to this group, send email to clojurescr...@googlegroups.com. >> Visit this group at http://groups.google.com/group/clojurescript. >> > -- > Daniel > -- Daniel -- You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com Note that posts from new members are moderated - please be patient with your first post. To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en --- You received this message because you are subscribed to the Google Groups "Clojure" group. To unsubscribe from this group and stop receiving emails from it, send an email to clojure+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
