On 18 July 2015 at 14:13, Andrey Antukh <n...@niwi.nz> wrote: > Hi! > > I have some, maybe controversial, questions... > > A little bit of context: > https://twitter.com/aphyr/status/621806683908542464 > > Why this is like a normal approach for managing third party contributions > to clojure core? This kind of things the only discourages the > contributions. Maybe I don't have more context about this concrete case, > but seems is not a unique. > And in general, I have the perception that the clojure development process > is a little bit opaque... >
Many people feel this way, but ultimately Clojure is Rich's project and I guess Cognitect's to some extent. If they don't want to run it like other more open & contribution-friendly OSS projects this is obviously their right. > > An other question: Why the great amount of clojure compiler code has no > indentation style and bunch of commented code. > > It is indented like a freshman. Sorry, I don't want offend any one, but > eyes hurt when reading the code compiler clojure (obviously I'm speaking > about the look and feel, and no the quality of the code). > > Some examples: > > Indentation (or maybe no indentation): > > https://github.com/clojure/clojure/blob/36d665793b43f62cfd22354aced4c6892088abd6/src/jvm/clojure/lang/APersistentVector.java#L86 > > Bunch of commented code and also no indentation: > > https://github.com/clojure/clojure/blob/master/src/jvm/clojure/lang/AMapEntry.java#L60 > > If you compare some clojure compiler code with different code snippets > from other languages, the indentation is clearly more cared: > > Kotlin: > https://github.com/JetBrains/kotlin/blob/master/core/descriptors/src/org/jetbrains/kotlin/types/AbstractClassTypeConstructor.java#L44 > Rust: > https://github.com/rust-lang/rust/blob/master/src/libstd/io/buffered.rs#L165 > Ceylon: > https://github.com/ceylon/ceylon-compiler/blob/master/src/com/redhat/ceylon/compiler/java/codegen/AttributeDefinitionBuilder.java#L233 > > This is a random list of code snippets from different compilers with > indentation that is more human friendly. > > I don't intend judge any one, but when a I learn Clojure compiler I expect > something different. I expect something more carefully done. > > No body thinks the same thing that me? > This topic resurfaces all the time. I'd certainly like to see the Java code "fixed", as its layout is highly unidiomatic (not to mention somewhat confusing). I doubt this will happen though - seems Rich doesn't think this is a big problem and AFAIK he's concerned that fixing the layout will affect currently submitted patches. Knowing all the hoops one has to jump to get a patch into Clojure, this doesn't sound like a pretty strong argument, but once again - his project, his rules. People seem to undervalue the value of polish in a project, as good style and overall tidiness set apart the good from the great. > > I think that have a sane, more open contribution policy, with clear and > more cared code formatting, is not very complicated thing and is going to > favor the clojure and its community. > Certainly. As far basic things go, I think it's also discouraging to see commit messages like: * tuples * tuning tuples * tuning tuples * fix And don't get me started on commented out code and Javadoc/Clojure docstrings. It'd be nice if at least improvements of cosmetic nature where easier to contribute, but alas - this also doesn't seem likely to happen. > > Andrey > -- > Andrey Antukh - Андрей Антух - <n...@niwi.nz> > http://www.niwi.nz > https://github.com/niwinz > > -- > You received this message because you are subscribed to the Google > Groups "Clojure" group. > To post to this group, send email to clojure@googlegroups.com > Note that posts from new members are moderated - please be patient with > your first post. > To unsubscribe from this group, send email to > clojure+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/clojure?hl=en > --- > You received this message because you are subscribed to the Google Groups > "Clojure" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to clojure+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com Note that posts from new members are moderated - please be patient with your first post. To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en --- You received this message because you are subscribed to the Google Groups "Clojure" group. To unsubscribe from this group and stop receiving emails from it, send an email to clojure+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
