On Dec 31, 2014, at 8:24 AM, Timothy Baldridge <tbaldri...@gmail.com> wrote: > This is one of the main reasons why I try to stay clear of heavy use of > invasive mocks. I can't tell you the amount of times I've looked at code and > realized that because of mocks nothing was really being tested at all. > Instead, think of mocks as the terminator in a test chain. That is to say, > they only exist to allow the program to continue executing. Tests should only > validate the behavior up to the call to the mock'd function, no further. > Otherwise you're testing your mock, and that causes all sorts of problems (as > you discovered).
I agree with Timothy here: we have about 6kloc test code (for a production code base of about 24kloc) and only have 25 with-redefs to stub just 8 functions in our Expectations code. In addition we use Expectations’ side-effects to mock just one function in four tests. Whenever we find ourselves needing to stub or mock in tests, we usually try to refactor the code so it’s easier to test fully without that. As for DB tear down & rebuild: we do a full tear down & rebuild at the start of running our suite - to create a baseline of test data - and have a few tests that tear down & rebuild their own specific test data but we try to keep this to a minimum (since it slows testing down). For some of the DB-heavy sections of our application, this is inevitable since we need to ensure all tests can be run multiple times without affecting their result, but we think carefully about any tests that have to do this. Sean Corfield -- (904) 302-SEAN An Architect's View -- http://corfield.org/ "Perfection is the enemy of the good." -- Gustave Flaubert, French realist novelist (1821-1880) -- You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com Note that posts from new members are moderated - please be patient with your first post. To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en --- You received this message because you are subscribed to the Google Groups "Clojure" group. To unsubscribe from this group and stop receiving emails from it, send an email to clojure+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
