I think this will be awesome. If the data structures made a no-op, at least the testing code should help.
Nice work Alexander! On Thursday, October 23, 2014 10:50:51 PM UTC-2, Alexander Hudek wrote: > > The implementation is API compatible but not compatible in terms of data > structures. I suppose it could still be integrated on a major version > change. In any case, I'm happy to donate the code if the core group wants. > Would have to get sign off from the other authors too. > > On Tuesday, October 21, 2014 5:59:20 PM UTC-4, Robin Heggelund Hansen > wrote: >> >> Any reason this isn't a patch to clojure proper? >> >> kl. 05:09:04 UTC+2 lørdag 4. oktober 2014 skrev Alexander Hudek følgende: >>> >>> Thanks to the wonderful work of Joel Holdbrooks, fast-zip now has >>> ClojureScript support. >>> See the benchmarks below. The ClojureScript benchmark only uses simple >>> compiler >>> optimizations. >>> >>> Git: https://github.com/akhudek/fast-zip >>> Clojars: [fast-zip "0.5.0"] >>> >>> CLJS has ~ 1.7x speedup: >>> >>> :clojure.zip x 116 ops/sec ±0.65% (83 runs sampled) >>> :fast-zip x 194 ops/sec ±0.85% (92 runs sampled) >>> Fastest is :fast-zip >>> >>> CLJ has ~ 5.2x speedup. >>> >>> ====================== >>> WARNING: Final GC required 1.467359386689346 % of runtime >>> Goal: Benchmark vector zip. >>> ----- >>> Case: :clojure.zip >>> Evaluation count : 60480 in 60 samples of 1008 calls. >>> Execution time mean : 1.002237 ms >>> Execution time std-deviation : 7.317531 µs >>> Execution time lower quantile : 990.607677 µs ( 2.5%) >>> Execution time upper quantile : 1.015757 ms (97.5%) >>> Overhead used : 2.442790 ns >>> >>> Case: :fast-zip >>> Evaluation count : 316140 in 60 samples of 5269 calls. >>> Execution time mean : 191.258856 µs >>> Execution time std-deviation : 2.819942 µs >>> Execution time lower quantile : 188.802833 µs ( 2.5%) >>> Execution time upper quantile : 198.838310 µs (97.5%) >>> Overhead used : 2.442790 ns >>> >>> Found 8 outliers in 60 samples (13.3333 %) >>> low-severe 4 (6.6667 %) >>> low-mild 4 (6.6667 %) >>> Variance from outliers : 1.6389 % Variance is slightly inflated by outliers >>> >>> -- You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com Note that posts from new members are moderated - please be patient with your first post. To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en --- You received this message because you are subscribed to the Google Groups "Clojure" group. To unsubscribe from this group and stop receiving emails from it, send an email to clojure+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
