I meant would not
On Mon, Aug 4, 2014 at 4:28 PM, David Nolen <dnolen.li...@gmail.com> wrote:
> I would rely on the behavior in the REPL to check this - the REPL
> compilation environment is likely different.
>
>
> On Mon, Aug 4, 2014 at 3:59 PM, Sam Ritchie <sritchi...@gmail.com> wrote:
>
>> Hey Herwig,
>>
>> I'm currently on [org.clojure/clojurescript "0.0-2261"], and I'm seeing
>> no munging:
>>
>> paddleguru.api.register.validation> (defn console [])
>> #<function console(){return null;
>> }>
>> nil
>> paddleguru.api.register.validation> (defn console [s] (.log js/console s))
>> #<function console(s){return console.log(s);
>> }>
>> nil
>> paddleguru.api.register.validation> (console "HI!")
>> "Error evaluating:" (console "HI!") :as
>> "paddleguru.api.register.validation.console.call(null,\"HI!\");\n"
>> #<TypeError: undefined is not a function>
>>
>> TypeError: undefined is not a function
>> at console (eval at <anonymous> (
>> https://local.paddleguru.com/cljs/dev/generated.js:83183:294),
>> <anonymous>:1:146)
>> at eval (eval at <anonymous> (
>> https://local.paddleguru.com/cljs/dev/generated.js:83183:294),
>> <anonymous>:1:108)
>> at eval (eval at <anonymous> (
>> https://local.paddleguru.com/cljs/dev/generated.js:83183:294),
>> <anonymous>:5:3)
>> at https://local.paddleguru.com/cljs/dev/generated.js:83183:289
>> at https://local.paddleguru.com/cljs/dev/generated.js:83197:4
>> at G__30641__2 (
>> https://local.paddleguru.com/cljs/dev/generated.js:23732:22)
>> at G__30641 [as call] (
>> https://local.paddleguru.com/cljs/dev/generated.js:23977:28)
>> at null.<anonymous> (
>> https://local.paddleguru.com/cljs/dev/generated.js:83238:80)
>> at goog.events.EventTarget.fireListeners (
>> https://local.paddleguru.com/cljs/dev/generated.js:42772:23)
>> at Function.goog.events.EventTarget.dispatchEventInternal_ (
>> https://local.paddleguru.com/cljs/dev/generated.js:42817:26)
>> nil
>>
>> Herwig Hochleitner <hhochleit...@gmail.com>
>> August 4, 2014 at 11:43 AM
>> Thomas, in my test, (defn console []) is munged aswell, so I'm guessing
>> that Sam is using a version from before
>> https://github.com/clojure/clojurescript/commit/f371c04d95a00cdda79c63f89f35088d62de8e73
>> Sam, is that correct?
>>
>> The observation that eval should be in js-globals is irrelevant, because
>> as I detailed a couple of messages ago, js-globals is wrong and should be
>> removed.
>> (fn x []) should never cast a shadow on js/x for any x.
>> So far, I believe David to agree. I commented on CLJS-833 to reflect this
>> point of view.
>>
>> Waiting on a statement towards fully removing gensyms from the compiler,
>> i.e. CLJS-401 revisited ...
>> --
>> You received this message because you are subscribed to the Google
>> Groups "Clojure" group.
>> To post to this group, send email to clojure@googlegroups.com
>> Note that posts from new members are moderated - please be patient with
>> your first post.
>> To unsubscribe from this group, send email to
>> clojure+unsubscr...@googlegroups.com
>> For more options, visit this group at
>> http://groups.google.com/group/clojure?hl=en
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "Clojure" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to clojure+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>> Thomas Heller <th.hel...@gmail.com>
>> August 4, 2014 at 10:40 AM
>> https://gist.github.com/thheller/4731f682665d38b1053c
>>
>> On Monday, August 4, 2014 3:34:33 PM UTC+2, Nicola Mometto wrote: --
>> You received this message because you are subscribed to the Google
>> Groups "Clojure" group.
>> To post to this group, send email to clojure@googlegroups.com
>> Note that posts from new members are moderated - please be patient with
>> your first post.
>> To unsubscribe from this group, send email to
>> clojure+unsubscr...@googlegroups.com
>> For more options, visit this group at
>> http://groups.google.com/group/clojure?hl=en
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "Clojure" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to clojure+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>> Nicola Mometto <brobro...@gmail.com>
>> August 4, 2014 at 7:34 AM
>> Try with (fn document [] js/document)
>>
>>
>> Thomas Heller <th.hel...@gmail.com>
>> August 4, 2014 at 7:30 AM
>> I was not able to reproduce Sam's initial problem.
>>
>> "eval" as I said does not appear in the :js-globals which seems like a
>> mistake.
>> --
>> You received this message because you are subscribed to the Google
>> Groups "Clojure" group.
>> To post to this group, send email to clojure@googlegroups.com
>> Note that posts from new members are moderated - please be patient with
>> your first post.
>> To unsubscribe from this group, send email to
>> clojure+unsubscr...@googlegroups.com
>> For more options, visit this group at
>> http://groups.google.com/group/clojure?hl=en
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "Clojure" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to clojure+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>> Herwig Hochleitner <hhochleit...@gmail.com>
>> August 4, 2014 at 7:11 AM
>> I dug a bit deeper to see where :js-globals came from and found the old
>> ticket for this exact issue: http://dev.clojure.org/jira/browse/CLJS-680
>> I propose that we remove it, because it's unnessecary when we gensym fn
>> names the same way as let bindings + blacklists are never a great solution,
>> but in the case of an open set of names (such as globals that can differ
>> from runtime to runtime), they are particularly awful.
>>
>> Ad reproducing the issue: Can the shadowing mechanism be influenced by
>> compiler flags such as :advanced?
>>
>>
>>
>> --
>> You received this message because you are subscribed to the Google
>> Groups "Clojure" group.
>> To post to this group, send email to clojure@googlegroups.com
>> Note that posts from new members are moderated - please be patient with
>> your first post.
>> To unsubscribe from this group, send email to
>> clojure+unsubscr...@googlegroups.com
>> For more options, visit this group at
>> http://groups.google.com/group/clojure?hl=en
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "Clojure" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to clojure+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>>
>> --
>> Sam Ritchie (@sritchie)
>> Paddleguru Co-Founder
>> 703.863.8561
>> www.paddleguru.com
>> Twitter <http://twitter.com/paddleguru> // Facebook
>> <http://facebook.com/paddleguru>
>>
>> --
>> You received this message because you are subscribed to the Google
>> Groups "Clojure" group.
>> To post to this group, send email to clojure@googlegroups.com
>> Note that posts from new members are moderated - please be patient with
>> your first post.
>> To unsubscribe from this group, send email to
>> clojure+unsubscr...@googlegroups.com
>> For more options, visit this group at
>> http://groups.google.com/group/clojure?hl=en
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "Clojure" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to clojure+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
--
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
---
You received this message because you are subscribed to the Google Groups
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
