Thank you Philipp, this is really helpful!

Marshall's guess where *read-eval* from is right. I didn't googled what 
does it mean, just left as-is from the Leiningen template.

Talking on replacement to join. For this function I'll link additional 
library. My question how this works: in C++ world, linker will eliminate 
all unused symbols (classes in this case?) from output binary. Is the same 
true for JVM/Clojure world? Will it bloat binary?
Why do you recommend update-in instead of assoc? First time I did this, 
than I saw using assoc in similar situation on ClojureDocs and  changed my 
mind.

I see your point about architecture. You suggest to make it more sequential 
(composition like: (f (g x))), instead of injecting actions like this:
(defn action [subaction]  ;; subaction is a function to pass control to
  (do ... (subaction ...)))

Thank you again.

On Monday, September 9, 2013 4:24:10 PM UTC-7, Igor Demura wrote:
>
> Hi Clojure community,
>
> (I tried codereview.stackaxchange.com before, but no responses where) I'm 
> Clojure newbie, and feel very excited about it and functional programming 
> in general. I wrote tiny app (59 lines of code) which renders a directory 
> tree to the terminal, filtering with a regex. I'm sure that my code is not 
> perfect and something could be done much better. I'll appreciate if you 
> could spent sometime to review it: 
> https://github.com/idemura/incub/tree/master/tree. Don't know where to 
> get help with this.
>
> Igor.
>
>

-- 
-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"Clojure" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to clojure+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to