On Wed, Jul 20, 2011 at 3:45 AM, Ambrose Bonnaire-Sergeant <
abonnaireserge...@gmail.com> wrote:

> On Wed, Jul 20, 2011 at 3:34 PM, Tassilo Horn <tass...@member.fsf.org>wrote:
>>
>>  > Here's the relevant Jira issue, feel free to voice your opinion.
>> >
>> > http://dev.clojure.org/jira/browse/LOGIC-10
>>
>> I had a quick look at your patch but I'm not sure if all of them comply
>> with the usual clojure conventions.  For example, `lcons' doesn't read
>> like a docstring for a function.  (Just nitpicking, I know how hard it
>> is to write good docstrings.)
>>
>>
> Agreed, thanks for looking. I must admit I'm not 100% happy with them, but
> I hoped
> they would spark some discussion.
>
> Possibly a comment might have been more appropriate than a patch.
>
> Ambrose
>

Thanks for doing this. I've posted my feedback on your patch.

David

-- 
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your 
first post.
To unsubscribe from this group, send email to
clojure+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/clojure?hl=en

Reply via email to