On Wed, Jun 23, 2010 at 7:17 AM, Stuart Halloway <stuart.hallo...@gmail.com> wrote: > I am trying to track down and solve the issues Phil Hazelden > reported on Hacker News [1]. I suspect that the XML issue was > this one: > > It appears that the code has moved on since this report-- the > emit-element fn mentions a :pad option but I don't see it being > used anywhere. Is there an issue here we should open a ticket > for?
Right, the way lazy-xml's emit works now is completely different. It now uses an XML Transformer which handles the indenting, as well as controlling character encoding, xml declaration, content escaping, etc. I think the mention of :pad in the emit-element docsctring is just out-of-date documentation, which I'd be happy to remove. emit-element is private anyway. On the other hand, clojure.xml/emit is in pretty bad shape and has been for a long time. It inserts newlines when it shouldn't and fails to escape text and attribute values. I'd be happy to see it use lazy-xml's implementation instead, unless people have issues with how lazy-xml does it. --Chouser http://joyofclojure.com/ -- You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com Note that posts from new members are moderated - please be patient with your first post. To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en
