Hi, On Jul 22, 2:31 pm, Howard Lewis Ship <hls...@gmail.com> wrote:
> Wow! I thought being on GitHub would mean that it wouldn't be > necessary to send patches via e-mail. (Disclaimer: Personal opinion following...) Pull requests are not a good device for open contribution. They require a lot of discipline. People seldom adhere to coding standards when submitting patches. Sometimes the changes are only superficial - missing edge cases (and hence introducing new bugs). Pull requests add quirked histories and commit messages to that. I prefer patches because they make it easier to clean up a contribution before it goes live. In that respect I like mercurial's patch queue better, because it's easier to iterate through such feedback loops. My 0.02€. Sincerely Meikel --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com Note that posts from new members are moderated - please be patient with your first post. To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en -~----------~----~----~----~------~----~------~--~---
