On Apr 5, 2009, at 12:19 PM, Stuart Halloway wrote:
(2) This function is moved from Steve Gilardi's sql.internal contrib. (Steve, I broke sql in r636 but I think I fixed it now. Are there tests I can run?)
Nothing automated yet. I use clojure.contrib.sql.test and then (db- write) (db-read) and some others. Your changes look good.
(3) I believe that the-str in miglayout can also be eliminated in favor of this standard version. Steve, do you agree?
Yes, that looks right. I'll make the change.
Questions: (1) I kept the original name "the-str" but would prefer "as-str". Community, what say ye?
I like as-str. I got "the-str" by way of Rich's the-ns and (I see now) the-class. "as-" suggests "copy constructor" (from C++) to me which I think is entirely appropriate.
I noticed the indentation changed for the ns form with your changes to sql.clj sql/internal.clj . Is the indentation you used produced by some tool?
--Steve
smime.p7s
Description: S/MIME cryptographic signature
