Ah, yeah - that's an odd situation that I didn't think about. I guess with clj we'll have to enumerate all the deps explicitly, although this would make the code vulnerable to dependency conflicts (the reason why we're doing this source rewriting to begin with).
On 28 January 2018 at 05:38, Alex Miller <a...@puredanger.com> wrote: > clj uses the dependencies for the published Maven artifact. The published > artifact has a pom with dependencies only on clojure and tools.nrepl, so > orchard is not a dependency that is found or can be traversed. Here's an > example snapshot pom in clojars, which is what any Maven user of this > artifact will see: > > https://clojars.org/repo/cider/cider-nrepl/0.17.0- > SNAPSHOT/cider-nrepl-0.17.0-20180123.225352-7.pom > > It seems that this is related to the use of the mranderson source-deps > plugin. The orchard dependency is renamed and included as part of the cider > source rather than depending on the actual namespaces. Thus, the > cider-nrepl artifact actually contains the orchard namespaces already, but > under a name like > cider.inlined-deps.orchard.v0v1v0-20180123v122522-8.orchard.misc > (note that this is snapshot version specific). > > So, this looks like clj is doing what is expected given the setup for > cider-nrepl. > > > On Sat, Jan 27, 2018 at 9:05 PM, Bozhidar Batsov <bozhi...@batsov.com> > wrote: > >> That's what I get if I don't specify the orchard dep explicitly: >> >> Exception in thread "main" java.io.FileNotFoundException: Could not >> locate orchard/misc__init.class or orchard/misc.clj on classpath., >> compiling:(cider/nrepl/middleware/pprint.clj:1:1) >> >> On 27 January 2018 at 20:07, Alex Miller <a...@puredanger.com> wrote: >> >>> Can you describe what “not works” looks like? Exception? Wrong dep? >>> >>> On Jan 27, 2018, at 11:04 AM, Bozhidar Batsov <bozhi...@batsov.com> >>> wrote: >>> >>> Well, I might have found one - seems transitive snapshot deps are not >>> handled properly (at least in the version of tools.deps that's shipped with >>> Clojure by default: >>> >>> clj -Sdeps '{:deps {cider/orchard {:mvn/version "0.1.0-SNAPSHOT"} >>> cider/cider-nrepl {:mvn/version "0.17.0-SNAPSHOT"} }}' -e '(require (quote >>> cider-nrepl.main)) (cider-nrepl.main/init ["cider.nrepl/cider-middleware >>> "])' >>> >>> This works, but this doesn't: >>> >>> clj -Sdeps '{:deps {cider/cider-nrepl {:mvn/version "0.17.0-SNAPSHOT"} >>> }}' -e '(require (quote cider-nrepl.main)) (cider-nrepl.main/init >>> ["cider.nrepl/cider-middleware"])' >>> >>> As orchard is a dep of cider-nrepl I find it pretty odd. All >>> non-snapshot deps seem to be processed normally. >>> >>> >>> >>> On 24 January 2018 at 19:39, Alex Miller <a...@puredanger.com> wrote: >>> >>>> Let me know if you find any bugs! :) >>>> >>>> On Wed, Jan 24, 2018 at 11:18 AM, Bozhidar Batsov <bozhi...@batsov.com> >>>> wrote: >>>> >>>>> That's exactly what I'm planning to do. Thanks for the help, Alex! And >>>>> thanks for working on this! >>>>> >>>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Clojure" group. >>>> To post to this group, send email to clojure@googlegroups.com >>>> Note that posts from new members are moderated - please be patient with >>>> your first post. >>>> To unsubscribe from this group, send email to >>>> clojure+unsubscr...@googlegroups.com >>>> For more options, visit this group at >>>> http://groups.google.com/group/clojure?hl=en >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "Clojure" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to clojure+unsubscr...@googlegroups.com. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Clojure" group. >>> To post to this group, send email to clojure@googlegroups.com >>> Note that posts from new members are moderated - please be patient with >>> your first post. >>> To unsubscribe from this group, send email to >>> clojure+unsubscr...@googlegroups.com >>> For more options, visit this group at >>> http://groups.google.com/group/clojure?hl=en >>> --- >>> You received this message because you are subscribed to a topic in the >>> Google Groups "Clojure" group. >>> To unsubscribe from this topic, visit https://groups.google.com/d/to >>> pic/clojure/RlHjnJPpFbU/unsubscribe. >>> To unsubscribe from this group and all its topics, send an email to >>> clojure+unsubscr...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Clojure" group. >>> To post to this group, send email to clojure@googlegroups.com >>> Note that posts from new members are moderated - please be patient with >>> your first post. >>> To unsubscribe from this group, send email to >>> clojure+unsubscr...@googlegroups.com >>> For more options, visit this group at >>> http://groups.google.com/group/clojure?hl=en >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "Clojure" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to clojure+unsubscr...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- >> You received this message because you are subscribed to the Google >> Groups "Clojure" group. >> To post to this group, send email to clojure@googlegroups.com >> Note that posts from new members are moderated - please be patient with >> your first post. >> To unsubscribe from this group, send email to >> clojure+unsubscr...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/clojure?hl=en >> --- >> You received this message because you are subscribed to a topic in the >> Google Groups "Clojure" group. >> To unsubscribe from this topic, visit https://groups.google.com/d/to >> pic/clojure/RlHjnJPpFbU/unsubscribe. >> To unsubscribe from this group and all its topics, send an email to >> clojure+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google > Groups "Clojure" group. > To post to this group, send email to clojure@googlegroups.com > Note that posts from new members are moderated - please be patient with > your first post. > To unsubscribe from this group, send email to > clojure+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/clojure?hl=en > --- > You received this message because you are subscribed to the Google Groups > "Clojure" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to clojure+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email to clojure@googlegroups.com Note that posts from new members are moderated - please be patient with your first post. To unsubscribe from this group, send email to clojure+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/clojure?hl=en --- You received this message because you are subscribed to the Google Groups "Clojure" group. To unsubscribe from this group and stop receiving emails from it, send an email to clojure+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
